Migrate pallet-paged-list to umbrella crate #6931
Conversation
|
had to add frame support for defensive trait |
kianenigma
added
the
T1-FRAME
| CloneNoBound, DebugNoBound, DefaultNoBound, EqNoBound, PartialEqNoBound, | ||
|
|
||
| use frame::{ | ||
| deps::{frame_support, sp_io}, |
There was a problem hiding this comment.
Usage of deps is generally discouraged, are they absolutely necessary in this file?
There was a problem hiding this comment.
This is an issue regarding the defensive! macro in frame_support that actually has a dependency with frame_support
I couldnt find a way to fix it without having to rewrite the macro
https://paritytech.github.io/polkadot-sdk/master/src/frame_support/traits/misc.rs.html#67-95
There was a problem hiding this comment.
for the other i will add it to the prelude
|
@ggwpez Hi Oliver ! Would you know if this line can be safely removed ? idk if it has any side effects on tests but it doesnt seem to do at first glance https://github.com/paritytech/polkadot-sdk/blame/master/substrate/frame/paged-list/src/paged_list.rs#L448 |
Part of #6504