-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omni-node: Tolerate failing metadata check #6923
Conversation
/cmd prdoc --bump patch --audience node_operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just activate the legacy
feature of frame-metadata
to have decoding work for all metadata's?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in DM, let's merge this and see if we can prevent this from happening in the future.
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6923-to-stable2407
git worktree add --checkout .worktree/backport-6923-to-stable2407 backport-6923-to-stable2407
cd .worktree/backport-6923-to-stable2407
git reset --hard HEAD^
git cherry-pick -x e6ddd3925693adbf538a438c94dc66e66eba9bed
git push --force-with-lease |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6923-to-stable2409
git worktree add --checkout .worktree/backport-6923-to-stable2409 backport-6923-to-stable2409
cd .worktree/backport-6923-to-stable2409
git reset --hard HEAD^
git cherry-pick -x e6ddd3925693adbf538a438c94dc66e66eba9bed
git push --force-with-lease |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6923-to-stable2412
git worktree add --checkout .worktree/backport-6923-to-stable2412 backport-6923-to-stable2412
cd .worktree/backport-6923-to-stable2412
git reset --hard HEAD^
git cherry-pick -x e6ddd3925693adbf538a438c94dc66e66eba9bed
git push --force-with-lease |
#6450 introduced metadata checks. Supported are metadata v14 and higher.
However, of course old chain-specs have a genesis code blob that might be on older version. This needs to be tolerated. We should just skip the checks in that case.
Fixes #6921