Snowbridge: Support bridging native ETH #6855
Open
+489
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alistair-singh
force-pushed
the
alistair/support-eth
branch
from
7a76da6 to
dd51d23
Compare
|
The approach looks good! |
|
Will approve once you've implemented the emulated test that verifies the full BH->AH path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
{ parents: 2, interior: X1(GlobalConsensus(Ethereum{chain_id: 1})) }when encountered.Onchain changes:
This will require a governance request to register native ETH (with the above location) in the foreign assets pallet and make it sufficient.
Related solidity changes: Snowfork/snowbridge#1354
TODO: