Extract the prometheus endpoint #6843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krayt78
changed the title
|
Hi @AndreiEres ! Could i get a first review of this please ? all tests are passing but i cant get pyroscope or prometheus to show data on my graphana, might be a skill issue on my end |
AndreiEres
requested changes
Dec 17, 2024
| use color_eyre::eyre; | ||
|
|
||
| /// Show if the app is running under Prometheus monitoring | ||
| pub(crate) fn is_prometheus_running() -> bool { |
There was a problem hiding this comment.
I'm not sure we need it
| } | ||
|
|
||
| /// Relaunch the app in Prometheus monitoring mode | ||
| pub(crate) fn relaunch_in_prometheus_mode() -> eyre::Result<()> { |
There was a problem hiding this comment.
We don't need to relaunch the bench. I assume you copied the approach with Valgrind, where we should relaunch the bench. Here, it's sufficient to initialize the endpoint.
| @@ -101,6 +102,10 @@ struct BenchCli { | |||
| /// Enable Cache Misses Profiling with Valgrind. Linux only, Valgrind must be in the PATH | |||
| pub cache_misses: bool, | |||
|
|
|||
| #[clap(long, default_value_t = false)] | |||
| /// Enable prometheus | |||
| pub prometheus: bool, | |||
There was a problem hiding this comment.
We need a port here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract the prometheus endpoint launching outside the test, as we already do with valgrind and pyroscope.
This is a PR for #3600