Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2412] Backport #6662 #6803

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[stable2412] Backport #6662 #6803

merged 1 commit into from
Dec 10, 2024

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #6662 into stable2412 from eskimor.

See the documentation on how to use this bot.

@eskimor @github-actions
Let's be a bit less strict here. (#6662)
fd5f8c3 
This might actually happen in non malicious cases.

Co-authored-by: eskimor <[email protected]>
(cherry picked from commit 5e0bcb0)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Dec 9, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@sandreim sandreim added the R0-silent Changes should not be mentioned in any release notes label Dec 9, 2024
@sandreim sandreim enabled auto-merge (squash) December 10, 2024 09:49
@EgorPopelyaev EgorPopelyaev merged commit f8a6cac into stable2412 Dec 10, 2024
226 of 251 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6662-to-stable2412 branch December 10, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreim sandreim sandreim approved these changes

@alexggh alexggh alexggh approved these changes

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexggh @sandreim @EgorPopelyaev @eskimor