Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #6662 #6802

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6662 into stable2409 from eskimor.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6662-to-stable2409
git worktree add --checkout .worktree/backport-6662-to-stable2409 backport-6662-to-stable2409
cd .worktree/backport-6662-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 5e0bcb0ee9788b7bb16ccfbda4fdc153b24c6386
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@sandreim sandreim added the R0-silent Changes should not be mentioned in any release notes label Dec 9, 2024
@sandreim sandreim marked this pull request as ready for review December 9, 2024 16:13
@sandreim sandreim enabled auto-merge (squash) December 10, 2024 12:51
@EgorPopelyaev EgorPopelyaev merged commit 8107ab0 into stable2409 Dec 10, 2024
218 of 278 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6662-to-stable2409 branch December 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants