Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating pallet-xcm-benchmarks to V2 #6618

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Migrating pallet-xcm-benchmarks to V2 #6618

merged 5 commits into from
Nov 28, 2024

Conversation

Krayt78
Copy link
Contributor

@Krayt78 Krayt78 commented Nov 22, 2024

Description

Migrated pallet-xcm-benchmarks to benchmaking syntax V2
This is part of #6202

@Krayt78 Krayt78 requested a review from a team as a code owner November 22, 2024 22:46
@Krayt78 Krayt78 mentioned this pull request Nov 22, 2024
Open
43 tasks
shawntabrizi
shawntabrizi approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my review could def be more in depth, but i scrolled through the PR, and everything looks sensible.

@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 27, 2024
@github-actions GitHub Actions
Copy link

Review required! Latest push from author must always be reviewed

@github-actions github-actions bot requested a review from re-gius November 27, 2024 14:56
@clangenb
Copy link
Contributor

Hmm, there was already an open PR for that: #6395

Please double-check if there is already PR for these things, and please review them fast, so that these mishaps don't occur.

@Krayt78
Copy link
Contributor Author

Krayt78 commented Nov 28, 2024

Hmm, there was already an open PR for that: #6395

Please double-check if there is already PR for these things, and please review them fast, so that these mishaps don't occur.

Sorry my bad didnt see this one, i thought you had only done the non generic one :/

@re-gius re-gius added this pull request to the merge queue Nov 28, 2024
Merged via the queue into paritytech:master with commit 23369ac Nov 28, 2024
195 of 200 checks passed
@Krayt78 Krayt78 deleted the migrating-pallet-xcm-benchmarks-to-v2 branch November 28, 2024 15:33
@clangenb clangenb mentioned this pull request Nov 28, 2024
Closed
@franciscoaguirre
Copy link
Contributor

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

Only members of paritytech/tip-bot-approvers have permission to request the creation of the tip referendum from the bot.

However, you can create the tip referendum yourself using Polkassembly or PolkadotJS Apps.

@acatangiu
Copy link
Contributor

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@acatangiu A referendum for a small (20 DOT) tip was successfully submitted for @Krayt78 (14AgwoPjcRiEEJgjfHmvAqkjdERCG26WEvQUoGLuBzcXKMS2 on polkadot).

Referendum number: 1329.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

Krayt78 added a commit to Krayt78/polkadot-sdk that referenced this pull request Dec 18, 2024
@Krayt78 @re-gius
Migrating pallet-xcm-benchmarks to V2 (paritytech#6618)
5153ede 
# Description
Migrated pallet-xcm-benchmarks to benchmaking syntax V2
This is part of paritytech#6202

---------

Co-authored-by: Giuseppe Re <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius approved these changes

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Krayt78 @clangenb @franciscoaguirre @acatangiu @shawntabrizi @re-gius