Migrating polkadot-runtime-parachains configuration benchmarking to V2 #6607
Conversation
| #[benchmark] | ||
| fn set_config_with_block_number() -> Result<(), BenchmarkError> { | ||
| #[extrinsic_call] | ||
| set_code_retention_period(RawOrigin::Root, One::one()); |
There was a problem hiding this comment.
This function (as well as set_max_code_size below) returns a Result, so that may be an Error. If you want the benchmarking function to return Result<(), BenchmarkError>, you should propagate the error from here. Otherwise, if the benchmarking function has an empty return type, you can assert_ok!(...) on the output of this function. Same below
There was a problem hiding this comment.
Yeah i see that they return a DispatchResult. How would one go to propagate the error from inside a extrinsic call?
Since those benchmarks previously didnt verify anything after the extrinsic call maybe the best call would be to just remove the return value ?
There was a problem hiding this comment.
Yeah, maybe it's better to remove the return value at this point since it's not really used
re-gius
added
R0-silent
|
bot bench cumulus-assets --runtime=asset-hub-westend --pallet=polkadot_runtime_parachains |
|
@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7904252 was started for your command Comment |
|
@re-gius Command |
Description
Migrating polkadot-runtime-parachains configuration benchmarking to the new benchmarking syntax v2.
This is a part of #6202