-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[polkadot-runtime-parachains] migrate disputes and disputes/slashing to benchmarking to bench v2 syntax #6577
[polkadot-runtime-parachains] migrate disputes and disputes/slashing to benchmarking to bench v2 syntax #6577
Conversation
@re-gius review reminder ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then in the normal pallet code you need to use report_dispute_lost_unsigned
as name for the weight function as well.
polkadot/runtime/parachains/src/disputes/slashing/benchmarking.rs
Outdated
Show resolved
Hide resolved
polkadot/runtime/parachains/src/disputes/slashing/benchmarking.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
…eport_dispute_lost_unsigned
Thanks @bkchr for the hints! Committed your changes and integrated them with the codebase! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty
@re-gius This PR has got the other review now. May I ask you to go ahead with the merge? |
/tip small |
The referendum has appeared on Polkassembly. |
ade1f75
[polkadot-runtime-parachains] migrate disputes and disputes/slashing to benchmarking to bench v2 syntax
Part of: