Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[polkadot-runtime-parachains] migrate disputes and disputes/slashing to benchmarking to bench v2 syntax #6577

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

clangenb
Copy link
Contributor

[polkadot-runtime-parachains] migrate disputes and disputes/slashing to benchmarking to bench v2 syntax

Part of:

@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. labels Nov 22, 2024
@clangenb
Copy link
Contributor Author

@re-gius review reminder ;)

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then in the normal pallet code you need to use report_dispute_lost_unsigned as name for the weight function as well.

@clangenb
Copy link
Contributor Author

Thanks @bkchr for the hints! Committed your changes and integrated them with the codebase! 👍

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty

@clangenb
Copy link
Contributor Author

@re-gius This PR has got the other review now. May I ask you to go ahead with the merge?

@re-gius re-gius added this pull request to the merge queue Dec 19, 2024
@re-gius
Copy link
Contributor

re-gius commented Dec 19, 2024

/tip small

Copy link

@re-gius A referendum for a small (20 DOT) tip was successfully submitted for @clangenb (16YCL3UVpVWQLGW3p3Zx4k5WAEp9W1DwdDnxAbyAaPxVxnp3 on polkadot).

Referendum number: 1360.
tip

Copy link

The referendum has appeared on Polkassembly.

Merged via the queue into paritytech:master with commit ade1f75 Dec 19, 2024
197 of 201 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants