Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pallet-xcm benchmarks to benchmark v2 syntax #6501

Merged

Conversation

clangenb
Copy link
Contributor

Migrates pallet-xcm benchmarks to benchmark v2 syntax

@clangenb clangenb requested a review from a team as a code owner November 15, 2024 15:38
@acatangiu acatangiu requested a review from a team November 20, 2024 12:40
@acatangiu acatangiu added the R0-silent Changes should not be mentioned in any release notes label Nov 20, 2024
@acatangiu
Copy link
Contributor

bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm

@command-bot
Copy link

command-bot bot commented Nov 20, 2024

@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-b4c01097-eec9-4756-834a-2e25c7f7e579 to cancel this command or bot cancel to cancel all commands in this pull request.

@acatangiu
Copy link
Contributor

Benchmarks are not compiling, please fix them, then run them for at least one runtime using command above for sanity checking results.

@command-bot
Copy link

command-bot bot commented Nov 20, 2024

@acatangiu Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277/artifacts/download.

@clangenb
Copy link
Contributor Author

clangenb commented Nov 20, 2024

Can you please elaborate? There was indeed a warning of unused variables because I forgot to push the last commit. This is fixed now.

However, the benchmarks did compile, and they did run successfully if I interpret the results correctly from: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7790277.

Were you hinting at the warnings, or is there a compile error I am not aware of?

Edit: Do I have the rights to run the bot command too as a rank I fellow?

@acatangiu
Copy link
Contributor

bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm

@command-bot
Copy link

command-bot bot commented Nov 20, 2024

@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7791751 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-08cd743b-fb6d-4212-af4e-51126cdad75e to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 20, 2024

@acatangiu Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7791751 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7791751/artifacts/download.

@re-gius re-gius added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 28, 2024
…llet-to-bench-v2-syntax

# Conflicts:
#	polkadot/xcm/pallet-xcm/src/benchmarking.rs
@clangenb clangenb force-pushed the cl/migrate-xcm-pallet-to-bench-v2-syntax branch from 38c36e8 to 24dab3c Compare December 16, 2024 07:40
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

polkadot/xcm/pallet-xcm/src/benchmarking.rs Outdated Show resolved Hide resolved
@re-gius re-gius added this pull request to the merge queue Dec 18, 2024
@re-gius
Copy link
Contributor

re-gius commented Dec 18, 2024

/tip small

Copy link

@re-gius A referendum for a small (20 DOT) tip was successfully submitted for @clangenb (16YCL3UVpVWQLGW3p3Zx4k5WAEp9W1DwdDnxAbyAaPxVxnp3 on polkadot).

Referendum number: 1356.
tip

Copy link

The referendum has appeared on Polkassembly.

Merged via the queue into paritytech:master with commit 6dd4a71 Dec 18, 2024
200 of 203 checks passed
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Dec 18, 2024
Migrates pallet-xcm benchmarks to benchmark v2 syntax

* Part of paritytech#6202
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Dec 18, 2024
Migrates pallet-xcm benchmarks to benchmark v2 syntax

* Part of paritytech#6202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants