-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pallet-recovery supports BlockNumberProvider
#6446
Merged
bkchr
merged 9 commits into
paritytech:master
from
AurevoirXavier:blocknumberprovider-recovery
Dec 22, 2024
Merged
Make pallet-recovery supports BlockNumberProvider
#6446
bkchr
merged 9 commits into
paritytech:master
from
AurevoirXavier:blocknumberprovider-recovery
Dec 22, 2024
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
reviewed
Nov 13, 2024
Co-authored-by: Guillaume Thiolliere <[email protected]>
AurevoirXavier
force-pushed
the
blocknumberprovider-recovery
branch
from
November 15, 2024 07:58
93b255d
to
976443e
Compare
It fails to compile:
|
/cmd prdoc --audience runtime_dev --bump major |
ideally the prdoc should mention what is changing, and in which context a migration is needed. You can take example on another PR:
|
gui1117
reviewed
Dec 6, 2024
gui1117
approved these changes
Dec 9, 2024
seadanda
reviewed
Dec 12, 2024
bkchr
approved these changes
Dec 12, 2024
Merged
via the queue into
paritytech:master
with commit Dec 22, 2024
88d900a
198 of 199 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make pallet-recovery supports
BlockNumberProvider
.Part of #6297.
Polkadot address: 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y