Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-builder: Use riscv32emac-unknown-none-polkavm.json target #6419

Merged
merged 41 commits into from
Dec 4, 2024

Conversation

jarkkojs
Copy link
Contributor

@jarkkojs jarkkojs commented Nov 9, 2024

Description

Closes #6335.

Integration

N/A

Review Notes

RuntimeTarget is converted to return path to the custom target JSON file

@jarkkojs jarkkojs requested a review from koute as a code owner November 9, 2024 01:34
@jarkkojs jarkkojs requested a review from athei November 9, 2024 01:36
@jarkkojs jarkkojs force-pushed the wasm-builder-riscv32emac branch 22 times, most recently from 5199aa3 to 005ec4a Compare November 9, 2024 07:09
@jarkkojs
Copy link
Contributor Author

jarkkojs commented Nov 9, 2024

How do I pass check-labels?

@jarkkojs jarkkojs force-pushed the wasm-builder-riscv32emac branch 5 times, most recently from 283e8b0 to 5205e58 Compare November 9, 2024 12:08
@jarkkojs jarkkojs requested a review from athei November 30, 2024 08:42
@jarkkojs
Copy link
Contributor Author

@athei, @koute: no other changes expect solved merge conflicts with Cargo.lock.

@github-actions github-actions bot requested a review from athei December 3, 2024 09:39
@github-actions github-actions bot requested a review from koute December 3, 2024 10:12
@jarkkojs jarkkojs disabled auto-merge December 3, 2024 15:21
@jarkkojs jarkkojs enabled auto-merge December 3, 2024 15:21
@jarkkojs jarkkojs added this pull request to the merge queue Dec 4, 2024
Merged via the queue into paritytech:master with commit 82117ad Dec 4, 2024
196 of 200 checks passed
@jarkkojs jarkkojs deleted the wasm-builder-riscv32emac branch December 4, 2024 18:49
sylvaincormier pushed a commit to sylvaincormier/polkadot-sdk that referenced this pull request Dec 4, 2024
…ytech#6419)

# Description

Closes paritytech#6335.

## Integration

N/A

## Review Notes

`RuntimeTarget` is converted to return path to the custom target JSON
file

---------

Signed-off-by: Jarkko Sakkinen <[email protected]>
Co-authored-by: Alexander Theißen <[email protected]>
Co-authored-by: Koute <[email protected]>
Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this pull request Dec 18, 2024
…ytech#6419)

# Description

Closes paritytech#6335.

## Integration

N/A

## Review Notes

`RuntimeTarget` is converted to return path to the custom target JSON
file

---------

Signed-off-by: Jarkko Sakkinen <[email protected]>
Co-authored-by: Alexander Theißen <[email protected]>
Co-authored-by: Koute <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update polkavm to the upstream toolchain version
3 participants