Use frame umbrella crate in pallet-babe & pallet-staking-reward-curve
#6412
+124
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowmead
changed the title
pallet-babepallet-babe & staking/reward-curve
snowmead
changed the title
pallet-babe & staking/reward-curvepallet-babe & pallet-staking-reward-curve
kianenigma
reviewed
Nov 12, 2024
kianenigma
reviewed
Nov 12, 2024
kianenigma
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Some small changes needed, but looks good so far.
@re-gius can you also review this please?
re-gius
added
the
T1-FRAME
re-gius
reviewed
Nov 13, 2024
91 tasks
re-gius
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Fix CI errors for approval (e.g., https://github.com/paritytech/polkadot-sdk/actions/runs/12035270577/job/33553951397?pr=6412 )
kianenigma
reviewed
Dec 3, 2024
substrate/frame/src/lib.rs
Outdated
| #[doc(no_inline)] | ||
| pub use sp_runtime::{DispatchErrorWithPostInfo, DispatchResultWithInfo, TokenError}; | ||
| pub use sp_runtime::{ | ||
| curve::PiecewiseLinear, BoundToRuntimeAppPublic, ConsensusEngineId, |
There was a problem hiding this comment.
To be a bit picky on the decision of what goes into the prelude and what doesn't, I suggest we ack that types that are used in pallet-babe only should not be in prelude. So I would remove ConsensusEngineId and DigestItem.
Rule of thumb: Whatever is used in at least 2+ pallets can be in prelude. Whatever not should use deps.
cc @re-gius
kianenigma
approved these changes
Dec 3, 2024
re-gius
approved these changes
Dec 20, 2024
re-gius
added
T2-pallets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifying pallet-babe and pallet-staking-reward-curve to use umbrella crate whilst adding a few types and preludes I deemed necessary for other pallets to potentially use as well.
These modifications are inspired by #5995
Review Notes
Some notable changes to umbrella crate preludes:
Exporting arithmetic prelude since this is used a lot throughout various pallets.
Exporting a few crypto primitives in the
hashingprelude.Maybe we should rename
hashingtocryptography, something more general to encompass hashing and cryptographic methods such as VRFs.Updated pallet-staking-reward-curve proc-macro to use umbrella crate since it was being used in pallet-babe. The change is reverse compatible as to not force all other pallets using this to update to the frame umbrella crate.
Removed std feature enabled dev-dependency pallets from pallet-babe
Polkadot address: 15Ug5Xtwf8wpD5PCKZcetXMh8NadVm3hHWBn8NQan3cqD