Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pool accounts view_function #6408

Draft
wants to merge 3 commits into
base: aj/view-functions
Choose a base branch
from

Conversation

re-gius
Copy link
Contributor

@re-gius re-gius commented Nov 7, 2024

Draft PR that would solve #6358 with pallet view functions building on top of #4722.

Providing bonded and reward account for nomination pool through a pallet view function.

@re-gius re-gius requested a review from kianenigma November 7, 2024 15:28
@re-gius re-gius added the T2-pallets This PR/Issue is related to a particular pallet. label Nov 7, 2024
@@ -4072,3 +4072,13 @@ impl<T: Config> sp_staking::OnStakingUpdate<T::AccountId, BalanceOf<T>> for Pall
}
}
}

#[pallet::view_functions]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to trigger this from anywhere now?

I can provide some pointers on how to do it manually:

  • The kitchensink runtime should have a new runtime API that will expose this.
  • You can manually hash the name and signature of this function (as per the view fn PR) to get the QueryId
  • You can use any of our developer consoles that can trigger a runtime API to call into the runtime API, and give the right query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants