Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate pallet-offences-benchmarking to benchmark v2 syntax #6300

Merged
merged 7 commits into from
Dec 2, 2024
Merged

migrate pallet-offences-benchmarking to benchmark v2 syntax #6300

merged 7 commits into from
Dec 2, 2024

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented Oct 30, 2024 •
edited
Loading

Migrates pallet-offences-benchmarking to benchmark v2 syntax.

Part of:

@clangenb clangenb requested a review from a team as a code owner October 30, 2024 16:39
clangenb
clangenb commented Oct 30, 2024
View reviewed changes
substrate/frame/offences/benchmarking/src/inner.rs
) -> Result<(Vec<IdentificationTuple<T>>, Vec<Offender<T>>), &'static str> {
) -> Result<Vec<IdentificationTuple<T>>, &'static str> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offenders was unused, and it was a private function, so I removed it.

substrate/frame/offences/benchmarking/src/mock.rs
Comment on lines +70 to +71
// corresponds to the opaque key id above
const KEY_TYPE_IDS: &'static [KeyTypeId] = &[KeyTypeId([100u8, 117u8, 109u8, 121u8])];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to fix genesis integrity check error.

@AurevoirXavier AurevoirXavier mentioned this pull request Oct 31, 2024
Open
43 tasks
@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 28, 2024
@clangenb
Copy link
Contributor Author

clangenb commented Nov 29, 2024 •
edited
Loading

@re-gius review bump :)

Edit: Sorry, I didn't see that you added the labels 15 hours ago, so I think this is on your radar.

@re-gius
Copy link
Contributor

re-gius commented Nov 29, 2024

bot bench substrate-pallet --features=runtime-benchmarks --pallet=pallet_offences_benchmarking

@command-bot
Copy link

command-bot bot commented Nov 29, 2024 •
edited
Loading

@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7840290 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_offences_benchmarking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-4f90760e-8a1d-47e5-8af1-d4a45d31f2ce to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 29, 2024

@re-gius Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_offences_benchmarking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7840290 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7840290/artifacts/download.

@re-gius
Copy link
Contributor

re-gius commented Nov 29, 2024

bot bench substrate-pallet --features=runtime-benchmarks --pallet=pallet_offences

@command-bot
Copy link

command-bot bot commented Nov 29, 2024 •
edited
Loading

@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7841389 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_offences. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 11-fb5a1ee4-1299-4e71-b92b-7ffb02221b7d to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 29, 2024

@re-gius Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_offences has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7841389 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7841389/artifacts/download.

@re-gius re-gius enabled auto-merge December 2, 2024 15:18
@re-gius re-gius added this pull request to the merge queue Dec 2, 2024
Merged via the queue into paritytech:master with commit 3d8da81 Dec 2, 2024
194 of 198 checks passed
@re-gius
Copy link
Contributor

re-gius commented Dec 2, 2024

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@re-gius A referendum for a small (20 DOT) tip was successfully submitted for @clangenb (16YCL3UVpVWQLGW3p3Zx4k5WAEp9W1DwdDnxAbyAaPxVxnp3 on polkadot).

Referendum number: 1333.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this pull request Dec 18, 2024
@clangenb @re-gius @Krayt78
migrate pallet-offences-benchmarking to benchmark v2 syntax (parityte…
29eb584 
…ch#6300)

Migrates pallet-offences-benchmarking to benchmark v2 syntax.

Part of:
* paritytech#6202

---------

Co-authored-by: Giuseppe Re <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius approved these changes

@gui1117 gui1117 gui1117 approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clangenb @re-gius @gui1117