Migrate pallet-preimage to benchmark v2

[AurevoirXavier]

Part of:

• Refactor pallets to V2 bench syntax #6202.

[ggwpez]

Why is this an expect now? The pallet is also usable without manager origin.
It returned BenchmarkError::Weightless before.

[AurevoirXavier]

I think that error is meaningless.

Same as:

polkadot-sdk/substrate/frame/treasury/src/benchmarking.rs

Lines 121 to 126 in 06debd0

	let origin =
	T::SpendOrigin::try_successful_origin().map_err(|_| BenchmarkError::Weightless)?;
	let beneficiary = T::Lookup::lookup(beneficiary_lookup.clone()).unwrap();
	#[extrinsic_call]
	_(origin as T::RuntimeOrigin, value, beneficiary_lookup);

It was not part of the benchmark(#[extrinsic_call]) code block. Additionally, I believe the original .expect message is more readable. So I reuse it.

What do you suggest?

[AurevoirXavier]

Also can be found here

polkadot-sdk/substrate/frame/lottery/src/benchmarking.rs

Line 50 in 06debd0

.expect("ManagerOrigin has no successful origin required for the benchmark");

[re-gius]

bot bench substrate-pallet --features=runtime-benchmarks --pallet=pallet_preimage

[command-bot]

@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7837857 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_preimage. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-91700d0f-b543-4f26-b92d-ad7c4657bcf1 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@re-gius Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_preimage has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7837857 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7837857/artifacts/download.

[re-gius]

/tip small

[substrate-tip-bot]

@re-gius A referendum for a small (20 DOT) tip was successfully submitted for @AurevoirXavier (156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y on polkadot).

Referendum number: 1323.

[substrate-tip-bot]

The referendum has appeared on Polkassembly.