-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Coretime chain] Add high assignment count mitigation to testnets #6022
Merged
+78
−4
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ce276fa
Add high assignment count mitigation to coretime chain on testnets
seadanda 3c50e26
Merge branch 'master' into donal-coretime-assignments-mitigation
seadanda bc02828
Add prdoc
seadanda e4fe96f
Merge branch 'master' into donal-coretime-assignments-mitigation
seadanda 1db4e32
Fix prdoc formatting
seadanda 4e0babd
Merge branch 'master' into donal-coretime-assignments-mitigation
seadanda c05ed3e
Update coretime.rs
seadanda 38e8342
Update coretime.rs
seadanda e3a47a4
Revert "Update coretime.rs"
seadanda e7af815
Merge branch 'master' into donal-coretime-assignments-mitigation
seadanda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
title: '[Coretime chain] Add high assignment count mitigation to testnets' | ||
doc: | ||
- audience: Runtime User | ||
description: | | ||
We can handle a maximum of 28 assignments inside one XCM, while it's possible to have 80 (if a | ||
region is interlaced 79 times). This can be chunked on the coretime chain side but currently the | ||
relay does not support this. This PR truncates the additional assignments on Rococo and Westend | ||
to mitigate this until the relay is fixed. The first 27 assignments are taken, the final 28th is | ||
used to pad with idle to complete the mask. Any other assignments are dropped. | ||
crates: | ||
- name: coretime-rococo-runtime | ||
bump: patch | ||
- name: coretime-westend-runtime | ||
bump: patch |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised that this is just a u16 in the broker pallet, rather than the type that the relay chain uses. This means we don't have FULL etc here. It will introduce another dependency and require an into anyway. I think longer term we should change the type in the broker pallet, but this will be a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the relay chain it is also a
u16
, but just a transparent wrapper aroundu16
. While this is a "breaking change" on the code level, it is not changing the storage layout or anything. Thus, changing it can be done very easily.