update solochain to use #[runtime] #5772
Conversation
Jan-Jan
added
C1-mentor
| RuntimeCall, | ||
| RuntimeEvent, | ||
| RuntimeError, | ||
| RuntimeOrigin, | ||
| RuntimeFreezeReason, | ||
| RuntimeHoldReason, | ||
| RuntimeSlashReason, | ||
| RuntimeLockId, | ||
| RuntimeTask | ||
| )] |
There was a problem hiding this comment.
not sure the philosophy we want to follow, but the template does not need all these derives. i could see an argument to use it either way
There was a problem hiding this comment.
I'm pro reducing this, but I cannot find the documentation explaining what each does. My personal preference would be to exclude them, and explain in the template why we are excluding them.
There was a problem hiding this comment.
if the type isnt being used anywhere in the file, you can pretty safely delete it.
There was a problem hiding this comment.
@Jan-Jan seems like the PR got merged without this being addressed. Looks like a good follow up. You can also look at the mock.rs in the parachain template and fix this there too.
|
bot fmt |
|
@shawntabrizi https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7415672 was started for your command Comment |
|
@shawntabrizi Command |
Description
#[frame::runtime]Templateinstead ofTemplateModuleIntegration
solochaintemplate and documentationReview Notes
solochaintemplate from construct_runtime! to #[runtime].Templateis our new convention, and preferred overTemplateModule.Out of scope
#[crate::runtime]with#[frame_support::runtime]