xcm-executor: validate destinations for ReserveWithdraw and Teleport transfers #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
added
the
A4-needs-backport
acatangiu
changed the title
acatangiu
force-pushed
the
validate-initiate-reserve-withdraw
branch
from
1e5b2ef to
3b92d33
Compare
acatangiu
changed the title
…transfers This change adds the required validation for stronger UX guarantees when using `InitiateReserveWithdraw` or `InitiateTeleport` XCM instructions. Execution of the instructions will fail if the local chain is not configured to trust the "destination" or "reserve" chain as a reserve/trusted-teleporter for the provided "assets". With this change, misuse of `InitiateReserveWithdraw`/`InitiateTeleport` fails on origin with no overall side-effects, rather than failing on destination (with side-effects to origin's assets issuance). The commit also makes the same validations for pallet-xcm transfers, and adds regression tests. Signed-off-by: Adrian Catangiu <[email protected]>
acatangiu
force-pushed
the
validate-initiate-reserve-withdraw
branch
from
3b92d33 to
583fdd7
Compare
…date-initiate-reserve-withdraw
…date-initiate-reserve-withdraw
franciscoaguirre
approved these changes
Sep 20, 2024
bkontur
approved these changes
Sep 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
…transfers (#5660) This change adds the required validation for stronger UX guarantees when using `InitiateReserveWithdraw` or `InitiateTeleport` XCM instructions. Execution of the instructions will fail if the local chain is not configured to trust the "destination" or "reserve" chain as a reserve/trusted-teleporter for the provided "assets". With this change, misuse of `InitiateReserveWithdraw`/`InitiateTeleport` fails on origin with no overall side-effects, rather than failing on destination (with side-effects to origin's assets issuance). The commit also makes the same validations for pallet-xcm transfers, and adds regression tests. --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: Branislav Kontur <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5660-to-stable2407
git worktree add --checkout .worktree/backport-5660-to-stable2407 backport-5660-to-stable2407
cd .worktree/backport-5660-to-stable2407
git reset --hard HEAD^
git cherry-pick -x b5ac7a9d59298eddcd0b6e9470afed7cc9e403d4
git push --force-with-lease |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
…transfers (#5660) This change adds the required validation for stronger UX guarantees when using `InitiateReserveWithdraw` or `InitiateTeleport` XCM instructions. Execution of the instructions will fail if the local chain is not configured to trust the "destination" or "reserve" chain as a reserve/trusted-teleporter for the provided "assets". With this change, misuse of `InitiateReserveWithdraw`/`InitiateTeleport` fails on origin with no overall side-effects, rather than failing on destination (with side-effects to origin's assets issuance). The commit also makes the same validations for pallet-xcm transfers, and adds regression tests. --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: Branislav Kontur <[email protected]> (cherry picked from commit b5ac7a9)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Sep 25, 2024
Backport #5660 into `stable2409` from acatangiu. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Adrian Catangiu <[email protected]>
|
This breaks existing test in ORML. The change is significant enough that it shouldn't be a patch version bump open-web3-stack/open-runtime-module-library#1011 also I can't find this PR in any release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the required validation for stronger UX guarantees when using
InitiateReserveWithdraworInitiateTeleportXCM instructions. Execution of the instructions will fail if the local chain is not configured to trust the "destination" or "reserve" chain as a reserve/trusted-teleporter for the provided "assets".With this change, misuse of
InitiateReserveWithdraw/InitiateTeleportfails on origin with no overall side-effects, rather than failing on destination (with side-effects to origin's assets issuance).The commit also makes the same validations for pallet-xcm transfers, and adds regression tests.