Improvements in solochain template #5111
Conversation
substrate/frame/src/lib.rs
Outdated
| @@ -233,6 +233,7 @@ pub mod runtime { | |||
| pub use sp_block_builder::*; | |||
| pub use sp_consensus_aura::*; | |||
| pub use sp_consensus_grandpa::*; | |||
| pub use sp_genesis_builder::*; | |||
There was a problem hiding this comment.
IMO we should directly pull in the Result here as GenesisBuilderResult. Maybe directly rename it in the crate to make it even more obvious.
There was a problem hiding this comment.
IMO we should directly pull in the
Resulthere asGenesisBuilderResult. Maybe directly rename it in the crate to make it even more obvious.
Exported it from the frame crate but didn't rename in sp-genesis-builder to avoid a breaking change.
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
| ConstBool, ConstU128, ConstU32, ConstU64, ConstU8, KeyOwnerProofSystem, Randomness, | ||
| StorageInfo, | ||
| use frame::{ | ||
| deps::{ |
There was a problem hiding this comment.
I mean, if we use deps, there is little benefit in using this crate overall, other than a cleaner Cargo.toml file.
I am tempted to even add a warning to deps to prevent deps being used recklessly..
| vec![] | ||
| } | ||
| } | ||
| } | ||
|
|
||
| pub mod interface { |
There was a problem hiding this comment.
This is a good idea, isolating what needs to be exported to node or other crates.
|
The T17 label was already allocated here: paritytech/labels#42 |
|
Will this be completed? we can find someone else to finish it perhaps. |
|
@kianenigma @gupnik FWIW I'd find this pretty useful if it got merged 🙏 |
@HCastano would you be down to finish it? I can mentor and re-evaluate :) |
This PR adds the following changes:
frameandpolkadot-sdkumbrella crates in the solochain templatesp-genesis-buildervia theframecrateserdefeature in theframecrate