Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcm-executor: Improve logging #4996

Merged
merged 2 commits into from
Jul 12, 2024
Merged

xcm-executor: Improve logging #4996

merged 2 commits into from
Jul 12, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jul 10, 2024

This improves logging in the xcm-executor to have better debugability when executing a XCM message.

@bkchr
xcm-executor: Improve logging
a87b26a 
This improves logging in the xcm-executor to have better debugability when executing a XCM message.
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jul 10, 2024
@bkchr bkchr requested review from a team as code owners July 10, 2024 17:03
acatangiu
acatangiu reviewed Jul 10, 2024
View reviewed changes
polkadot/xcm/xcm-executor/src/traits/should_execute.rs
Comment on lines +78 to +87
tracing::trace!(
target: "xcm::should_execute",
?origin,
?instructions,
?max_weight,
?properties,
?error,
%barrier,
"did not pass barrier",
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using this, but for some reason this never gets printed 🤷‍♂️ too late in the day now to investigate why

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.

Should work with #4863

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes, I was missing #4863 on my branch, works now, thanks!

@bkchr
Copy link
Member Author

bkchr commented Jul 10, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Jul 10, 2024 •
edited
Loading

"$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" was queued.

Comment bot cancel 4-6ada551b-24d1-4214-a15b-e94bdd8e3fdc to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jul 10, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result:

Error: remote: HTTP Basic: Access denied. The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password. See https://gitlab.parity.io/help/topics/git/troubleshooting_git#error-on-git-fetch-http-basic-access-denied
fatal: Authentication failed for 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/'
Error: remote: HTTP Basic: Access denied. The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password. See https://gitlab.parity.io/help/topics/git/troubleshooting_git#error-on-git-fetch-http-basic-access-denied
fatal: Authentication failed for 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/'
    at ChildProcess.<anonymous> (/app/build/shell.js:73:39)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess.emit (node:domain:489:12)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:303:5)

@bkchr
Copy link
Member Author

bkchr commented Jul 10, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Jul 10, 2024 •
edited
Loading

"$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" was queued.

Comment bot cancel 5-4d64d0f9-c72b-40a1-8bac-86388ceb1ba8 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jul 10, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result:

Error: remote: HTTP Basic: Access denied. The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password. See https://gitlab.parity.io/help/topics/git/troubleshooting_git#error-on-git-fetch-http-basic-access-denied
fatal: Authentication failed for 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/'
Error: remote: HTTP Basic: Access denied. The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password. See https://gitlab.parity.io/help/topics/git/troubleshooting_git#error-on-git-fetch-http-basic-access-denied
fatal: Authentication failed for 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/'
    at ChildProcess.<anonymous> (/app/build/shell.js:73:39)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess.emit (node:domain:489:12)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:303:5)

@bkchr bkchr added this pull request to the merge queue Jul 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 12, 2024
@acatangiu acatangiu added this pull request to the merge queue Jul 12, 2024
Merged via the queue into master with commit 2a555c3 Jul 12, 2024
154 of 158 checks passed
@acatangiu acatangiu deleted the bkchr-xcm-executor-logging branch July 12, 2024 08:44
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 13, 2024
@bkchr @TomaszWaszczyk
xcm-executor: Improve logging (paritytech#4996)
d9c2595 
This improves logging in the xcm-executor to have better debugability
when executing a XCM message.
ordian added a commit that referenced this pull request Jul 15, 2024
@ordian
merge master and resolve conflicts
ce5de33 
* master: (120 commits)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  fixed cmd bot commenting not working (#5000)
  Explain usage of `<T: Config>` in FRAME storage + Update parachain pallet template  (#4941)
  Expose metadata-hash feature from polkadot crate (#4886)
  Add `MAX_INSTRUCTIONS_TO_DECODE` to XCMv2 (#4978)
  add notices to the implementer's guide docs that changed for elastic scaling (#4983)
  `polkadot-parachain` simplifications and deduplications (#4916)
  Update Templates README docs (#4980)
  allow clear_origin in safe xcm builder (#4777)
  litep2p/peerstore: Fix bump last updated time (#4971)
  Make `tracing::log` work in the runtime (#4863)
  sp-core: Improve docs generated by `generate_feature_enabled_macro` (#4968)
  [Backport] Version bumps  and  prdocs reordering from 1.14.0 (#4955)
  Assets: can_decrease/increase for destroying asset is not successful (#3286)
  ...
ordian added a commit that referenced this pull request Jul 18, 2024
@ordian
Merge branch 'master' into ao-fix-backing-filtering-on-disputes
f75dcd7 
* master: (125 commits)
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  ...
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@bkchr @TarekkMA
xcm-executor: Improve logging (paritytech#4996)
6964fd0 
This improves logging in the xcm-executor to have better debugability
when executing a XCM message.
ordian added a commit that referenced this pull request Aug 6, 2024
@ordian
Merge branch 'master' into ao-account-for-enact-candidate-weight
e6978fd 
* master: (130 commits)
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkchr @franciscoaguirre @acatangiu