asset-hub-rococo: genesis config presets added #3996

michalkucharczyk · 2024-04-05T10:33:12Z

Gensis config presets moved from polkadot-parachain binary into asset-hub-rococo runtime.

relates to: #3944

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs

michalkucharczyk · 2024-06-08T13:43:11Z

Do you think we can merge it?

bkontur · 2024-06-10T07:37:04Z

cool, I would need this for other testnet runtimes also: #4405

cumulus/parachains/common/src/genesis_config_helpers.rs

seadanda

Just one query about naming, but looks like a nice change.

seadanda · 2024-06-18T15:08:15Z

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs

+pub mod preset_names {
+	pub const PRESET_DEVELOPMENT: &str = "development";
+	pub const PRESET_LOCAL: &str = "local";
+	pub const PRESET_GENESIS: &str = "genesis";


This has previously been called "Live", any reason for the change to genesis?

@seadanda Thanks for spotting this. I took the name from here (and I know it is far from being perfect) :

polkadot-sdk/cumulus/polkadot-parachain/src/command.rs

Lines 171 to 172 in 6daa939

"asset-hub-rococo-genesis" =>

Box::new(chain_spec::asset_hubs::asset_hub_rococo_genesis_config()),

But I am open to any other name. Should I call it "live"?
I am not sure what is purpose of this particular config.

ps. I did not notice Live name anywhere.

Suggested change

pub const PRESET_GENESIS: &str = "genesis";

pub const PRESET_GENESIS: &str = "live";

?

Not sure we need this at all? live and genesis are really not that expressive names...

I mean I assume it is for generating the gensis of the live networks, but yeah we probably don't need it.

Live is what I had seen along with Local and Development for the ChainTypes

I also am not too sure what that specific config is for. Is that the only place this preset will be used? Maybe my reasoning for live is actually wrong then here

Actually preset names here are simply reflecting the names of predefined chain-specs exported by polkadot-parachain binary which are:

"asset-hub-rococo-dev" "asset-hub-rococo-local" "asset-hub-rococo-genesis"

see code here:
https://github.com/paritytech/polkadot-sdk/blob/09035a7d5d14fc3f2df3db304cd0fcc8fc9ed27b/cumulus/polkadot-parachain/src/chain_spec/mod.rs#L117C1-L120C90

This one: "asset-hub-rococo-genesis", actually is a ChainType::Live, so I can rename it. But it is also not very informative name. Not sure what is the purpose of each chain-spec flavor.

For now I propose to keep it for compatibility reasons, we can always remove them in future.
I also would prefer the keep "genesis" name to allow easy mapping to corresponding chain-spec name,

At some point we will be removing predefined (e.g. "asset-hub-rococo-dev|local|genesis") chain spec flavors from the omni-node. We could remove unused presets at the same time.

@kianenigma what are your thoughts on this?

cumulus/parachains/common/src/genesis_config_helpers.rs

Co-authored-by: Dónal Murray <[email protected]>

cumulus/parachains/common/src/genesis_config_helpers.rs

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs

bkchr · 2024-06-19T14:49:59Z

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs

+pub mod preset_names {
+	pub const PRESET_DEVELOPMENT: &str = "development";
+	pub const PRESET_LOCAL: &str = "local";
+	pub const PRESET_GENESIS: &str = "genesis";


Not sure we need this at all? live and genesis are really not that expressive names...

bkchr · 2024-06-19T14:50:56Z

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs

+	serde_json::json!({
+		"balances": crate::BalancesConfig {


Why are we not using the concrete GenesisConfig type here? And then transform this into a json?

A preset is meant to be patch. This is the only reason.

If GenesisConfig struct would be used here, then the preset would contain all the fields of the genesis config. That would be less convenient / a little harder to read when displaying presets with some external tools (e.g. chain-spec-builder).

bkchr · 2024-06-19T14:51:34Z

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs

+pub mod preset_names {
+	pub const PRESET_DEVELOPMENT: &str = "development";
+	pub const PRESET_LOCAL: &str = "local";
+	pub const PRESET_GENESIS: &str = "genesis";


I mean I assume it is for generating the gensis of the live networks, but yeah we probably don't need it.

bkchr · 2024-06-19T14:52:09Z

Left some nitpicks. Generally looking good. Good work 👍

Co-authored-by: Bastian Köcher <[email protected]>

…o-preset

paritytech-cicd-pr · 2024-08-30T13:13:41Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7198204

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs

bkontur

looks good, just one nit,
so I will adjust and continue with others here: #5327

skunert · 2024-08-30T14:32:46Z

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs

+
+/// Generate the session keys from individual elements.
+///
+/// The input must be a tuple of individual keys (a single arg for now since we have just one key).


Not sure about this comment and naming, why exactly will this change to a tuple?

Just moved that function from other place w/o thinking too much about it:
https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/polkadot-parachain/src/chain_spec/asset_hubs.rs#L37

asset-hub-rococo: presets added

b9b5455

michalkucharczyk mentioned this pull request Apr 5, 2024

Fix polkadot-parachain to work just with chain-spec #3944

Closed

michalkucharczyk added 2 commits April 5, 2024 12:35

Cargo.lock

5d1fa2b

make zepter happy

38f67dd

michalkucharczyk added R0-silent Changes should not be mentioned in any release notes T14-system_parachains This PR/Issue is related to system parachains. labels Apr 5, 2024

michalkucharczyk requested review from bkontur and seadanda April 5, 2024 11:05

michalkucharczyk commented Apr 5, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs Outdated Show resolved Hide resolved

michalkucharczyk commented Apr 5, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs Outdated Show resolved Hide resolved

michalkucharczyk commented Apr 5, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs Outdated Show resolved Hide resolved

michalkucharczyk commented Apr 5, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs Show resolved Hide resolved

michalkucharczyk mentioned this pull request May 10, 2024

Add zombienet integration polkadot-fellows/runtimes#307

Merged

1 task

michalkucharczyk added 3 commits May 31, 2024 13:29

Merge branch 'master' into mku-asset-hub-rococo-preset

9bc943c

Merge branch 'master' into mku-asset-hub-rococo-preset

769fc9d

some improvements

f3e7e4d

michalkucharczyk marked this pull request as ready for review June 8, 2024 13:42

michalkucharczyk requested a review from kianenigma June 8, 2024 13:43

michalkucharczyk requested a review from a team June 8, 2024 13:45

bkontur reviewed Jun 10, 2024

View reviewed changes

cumulus/parachains/common/src/genesis_config_helpers.rs Outdated Show resolved Hide resolved

SAFE_XCM_VERSION move to constants

0df7dc5

michalkucharczyk requested a review from bkontur June 10, 2024 09:48

seadanda approved these changes Jun 18, 2024

View reviewed changes

Apply suggestions from code review

6db7077

Co-authored-by: Dónal Murray <[email protected]>

bkchr approved these changes Jun 19, 2024

View reviewed changes

michalkucharczyk and others added 2 commits August 30, 2024 12:59

Update cumulus/parachains/common/src/genesis_config_helpers.rs

7e82cae

Co-authored-by: Bastian Köcher <[email protected]>

Merge remote-tracking branch 'origin/master' into mku-asset-hub-rococ…

fe71694

…o-preset

after merge fix

362d8a2

michalkucharczyk mentioned this pull request Aug 30, 2024

sp_genesis_builder::PresetId: improvement #5532

Open

use vec / format fixes

e7dac38

bkontur mentioned this pull request Aug 30, 2024

Moved presets to the testnet runtimes #5327

Merged

8 tasks

prdoc added

ccdfe51

bkontur reviewed Aug 30, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs Outdated Show resolved Hide resolved

bkontur approved these changes Aug 30, 2024

View reviewed changes

skunert approved these changes Aug 30, 2024

View reviewed changes

fn preset_names added

13f411d

michalkucharczyk added this pull request to the merge queue Aug 30, 2024

Merged via the queue into master with commit 95f3977 Aug 30, 2024
184 of 186 checks passed

michalkucharczyk deleted the mku-asset-hub-rococo-preset branch August 30, 2024 16:07

ggwpez mentioned this pull request Sep 9, 2024

Parent issue for stable2409 LTS release #5583

Closed

github-actions bot mentioned this pull request Oct 8, 2024

Update polkadot-sdk from stable2407 to stable2409 moonbeam-foundation/moonbeam#2994

Closed

github-actions bot mentioned this pull request Dec 5, 2024

Update polkadot-sdk from stable2407 to stable2409-2 moonbeam-foundation/moonbeam#3075

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

asset-hub-rococo: genesis config presets added #3996

asset-hub-rococo: genesis config presets added #3996

michalkucharczyk commented Apr 5, 2024

michalkucharczyk commented Jun 8, 2024

bkontur commented Jun 10, 2024

seadanda left a comment

seadanda Jun 18, 2024

michalkucharczyk Jun 18, 2024

michalkucharczyk Jun 18, 2024

bkchr Jun 19, 2024

bkchr Jun 19, 2024

seadanda Jun 19, 2024

michalkucharczyk Aug 30, 2024

michalkucharczyk Aug 30, 2024 •

edited

Loading

michalkucharczyk Aug 30, 2024

bkchr Jun 19, 2024

bkchr Jun 19, 2024

michalkucharczyk Aug 30, 2024

bkchr Jun 19, 2024

bkchr commented Jun 19, 2024

paritytech-cicd-pr commented Aug 30, 2024

bkontur left a comment

skunert Aug 30, 2024

michalkucharczyk Aug 30, 2024 •

edited

Loading

	"asset-hub-rococo-genesis" =>
	Box::new(chain_spec::asset_hubs::asset_hub_rococo_genesis_config()),

	pub const PRESET_GENESIS: &str = "genesis";
	pub const PRESET_GENESIS: &str = "live";

asset-hub-rococo: genesis config presets added #3996

asset-hub-rococo: genesis config presets added #3996

Conversation

michalkucharczyk commented Apr 5, 2024

michalkucharczyk commented Jun 8, 2024

bkontur commented Jun 10, 2024

seadanda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michalkucharczyk Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkchr commented Jun 19, 2024

paritytech-cicd-pr commented Aug 30, 2024

bkontur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michalkucharczyk Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

michalkucharczyk Aug 30, 2024 •

edited

Loading

michalkucharczyk Aug 30, 2024 •

edited

Loading