Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pallet-balances]
burn_allow_death
extrinsic #3964[pallet-balances]
burn_allow_death
extrinsic #3964Changes from 2 commits
d1fadb2
e9c5ee5
cc8641d
fbfcb62
f1db75e
0094a2c
b8f4f48
d9493fe
2c7c067
58268e4
56d3379
45d191f
d8ade46
41d70ef
293ee0f
79db74f
1b48ad5
9b6c3ce
6979ffa
21077a8
1617050
5657da1
3d48ae6
ac976b8
1a07ca2
976c936
ba662db
11a0475
eb29289
16f342a
a42db38
eb2f431
53e5112
fa0a300
051674d
27618af
f10a8eb
49b2ba7
d6d9936
851e629
190ca18
be3e92f
24c6422
04f75af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional call is overkill, but a
keep_alive: bool
similar to thetransfer_all
would be fine i think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind doing that, but will need to change this function signature:
https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/support/src/traits/tokens/fungible/regular.rs#L260
It might end being a slightly lager change, hope that's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated per request.
Will need help/suggestion with the remaining TODOs in the PR summary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you said in another PR that current review process isn't sustainable (I assume due to human resources), but is there someone else we can ask to take a look at the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggwpez sorry for the tag but could you please give a timeline when this can be checked out? Can we get someone else to review it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it is best to ask in chat for review. We have the open
#fellowship-open-channel:parity.io
channel for that. I invited you.Otherwise it can get lost or not have any priority...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.