-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pallet-asset-rewards
#3926
base: master
Are you sure you want to change the base?
Conversation
pallet-staking-rewards
pallet-asset-rewards
@gui1117 thank you for review! all comments should addressed now |
bot bench cumulus-assets --pallet=pallet_asset_rewards --runtime asset-hub-rococo |
@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7341344 was started for your command Comment |
…=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_asset_rewards
@muharem Command |
bot bench cumulus-assets --pallet=pallet_asset_rewards --runtime asset-hub-westend |
@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7343877 was started for your command Comment |
…=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_asset_rewards
@muharem Command |
bot bench-all pallet --pallet=pallet_asset_rewards |
@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7360419 was started for your command Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@muharem Command |
AssetIdForTrustBackedAssets, | ||
xcm::v4::Location, | ||
>, | ||
xcm::v4::Location, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xcm::v5::Location
everywhere, but when you rebase/merge master, it should be fixed
All GitHub workflows were cancelled due to failure one of the required jobs. |
Closes #3149
Description
This PR introduces
pallet-asset-rewards
, which allows accounts to be rewarded for freezingfungible
tokens. The motivation for creating this pallet is to allow incentivising LPs.See the pallet docs for more info about the pallet.
Runtime changes
The pallet has been added to
asset-hub-rococo
asset-hub-westend
The
NativeAndAssets
fungibles
Union did not containPoolAssets
, so it has been renamedNativeAndNonPoolAssets
A new
fungibles
UnionNativeAndAllAssets
was created to encompass all assets and the native token.TODO
fungibles::freeze::Mutate
#3342) and re-run benchmarks