Patch for generic AssetHub test-cases #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
reviewed
Feb 20, 2024
Cargo.lock
Outdated
| ] | ||
|
|
||
| [[package]] | ||
| name = "pallet-asset-conversion" | ||
| version = "10.0.0" | ||
| version = "11.0.0" |
There was a problem hiding this comment.
It seems to bump all crates?
I think it should only bump the simple-mermaid crate.
There was a problem hiding this comment.
I think it just fixes Cargo.lock, if you check pallet-asset-conversion in this branch:
[package]
name = "pallet-asset-conversion"
version = "11.0.0"
There was a problem hiding this comment.
@Morganamilo do you know why the lock file is out of sync with this branch?
…fferent_consensus_works`
franciscoaguirre
approved these changes
Feb 20, 2024
acatangiu
approved these changes
Feb 20, 2024
This was referenced Feb 20, 2024
acatangiu
pushed a commit
that referenced
this pull request
Feb 20, 2024
Backport of #3340 Includes #3404 to fix compilation --------- Co-authored-by: Branislav Kontur <[email protected]>
fellowship-merge-bot bot
pushed a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Mar 5, 2024
Based on bump to [`[email protected]`](#159). Attached result of `cargo upgrade -v --pinned --incompatible` [cargo-upgrade-version-bump.log](https://github.com/polkadot-fellows/runtimes/files/14281072/cargo-upgrade-version-bump.log) ~~## For reviewers~~ ~~This PR is against `polkadot-fellows`'s main to bring it to the fellows repo, but if you want to see a real diff relevant to the `[email protected]` update please check: bkontur/runtimes@bko-bump-to-1.6...bkontur:runtimes:bko-bump-to-1.7.~~ ## TODO - [x] fix compilation - [x] apply patch for AssetHub tests: paritytech/polkadot-sdk#3404 - [x] apply patch for `coretime` paritytech/polkadot-sdk#3497 see [comment](#187 (comment)) - [x] fix integration tests - fix after #185 - [x] fix benchmarks (also try them) - [x] apply patch for `pallet-xcm` benchmarks paritytech/polkadot-sdk#3465 - [x] check ranked collectives: - [x] `ExchangeOrigin` see [comment](#187 (comment)) - [x] `MemberSwappedHandler` / `BenchmarkSetup` see [comment](#187 (comment)) --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: Ross Bulat <[email protected]> Co-authored-by: Alain Brenzikofer <[email protected]> Co-authored-by: eskimor <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: brenzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR/fix externalizes the checks for received fees from the generic
receive_reserve_asset_deposited_from_different_consensus_workstest case, allowing the target runtime to adjust them according to the actual XCM configuration.This PR will unblock failing tests for AssetHubs for
polkadot-fellowsbump to[email protected]here.Expected released patch version for
asset-test-utilsas8.0.1