Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds MaxRank Config in pallet-core-fellowship #3393

Merged
merged 45 commits into from
May 16, 2024
Merged

Adds MaxRank Config in pallet-core-fellowship #3393

merged 45 commits into from
May 16, 2024

Conversation

Doordashcon
Copy link
Contributor

resolves #3315

@Doordashcon Doordashcon changed the title Adds max_rank() method in RankedMember Adds max_rank() method in RankedMember Trait Feb 19, 2024
@Doordashcon Doordashcon marked this pull request as ready for review February 27, 2024 10:12
@Doordashcon Doordashcon requested a review from a team as a code owner February 27, 2024 10:12
@Doordashcon Doordashcon requested a review from a team as a code owner March 11, 2024 11:08
bkchr
bkchr reviewed Apr 3, 2024
View reviewed changes
substrate/frame/core-fellowship/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/ranked-collective/src/lib.rs Outdated Show resolved Hide resolved
@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 8, 2024 15:11
muharem
muharem reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@muharem muharem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure benchmarks run without failure by running them.

bot bench substrate-pallet --pallet=pallet_core_fellowship
for more info comment bot help

substrate/frame/core-fellowship/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/core-fellowship/src/lib.rs Outdated Show resolved Hide resolved
@Doordashcon
Copy link
Contributor Author

Doordashcon commented Apr 12, 2024 •
edited
Loading

please make sure benchmarks run without failure by running them.

@muharem All the benchmarks run fine locally, is there anything I may be missing?

@muharem
Copy link
Contributor

muharem commented Apr 12, 2024

bot bench substrate-pallet --pallet=pallet_core_fellowship

@command-bot
Copy link

command-bot bot commented Apr 12, 2024 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5901077 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_core_fellowship. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-5d92078c-89ed-4678-8e92-82647c748903 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 12, 2024

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_core_fellowship has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5901077 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5901077/artifacts/download.

@Doordashcon
Copy link
Contributor Author

Hopefully this is ready for final review @muharem @bkchr @ggwpez 🙏

@Doordashcon Doordashcon changed the title Adds max_rank() method in RankedMember Trait Adds MaxRank Config in pallet-core-fellowship Apr 30, 2024
@Doordashcon Doordashcon mentioned this pull request May 3, 2024
Open
@bkchr bkchr added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label May 16, 2024
@bkchr bkchr enabled auto-merge May 16, 2024 15:36
@bkchr bkchr added this pull request to the merge queue May 16, 2024
Merged via the queue into paritytech:master with commit d5fe478 May 16, 2024
148 of 150 checks passed
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@Doordashcon @bkchr @hitchhooker
Adds MaxRank Config in pallet-core-fellowship (paritytech#3393)
30ba026 
resolves paritytech#3315

---------

Co-authored-by: doordashcon <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@Doordashcon @bkchr @TarekkMA
Adds MaxRank Config in pallet-core-fellowship (paritytech#3393)
9a4581c 
resolves paritytech#3315

---------

Co-authored-by: doordashcon <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
This was referenced Aug 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@muharem muharem muharem left review comments

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add max_rank() method in RankedMember trait
4 participants
@Doordashcon @muharem @bkchr @ggwpez