fix(zombienet): docker img version to use in merge queues for bridges
#3337
Conversation
pepoviola
added
R0-silent
| rules: | ||
| - !reference [.build-refs, rules] | ||
| - if: $CI_COMMIT_REF_NAME =~ /^gh-readonly-queue.*$/ |
There was a problem hiding this comment.
I think we should delete this if the variable assignment has been moved.
There was a problem hiding this comment.
I think we should keep, since this rule make these test only run on merge queues.
There was a problem hiding this comment.
These tests should also run in the CI. And they seem to be running. If this rule makes them only run in merge queues it's by mistake.
Ahh, that true. We should export the final var here. I will fix it. |
|
@pepoviola I see that there are still some errors. Are you working on them ? If not I can try to fix them since it's a bridge testing error. Please let me know how you prefer. |
|
Hi @serban300, thanks for the heads up. Let me check and fix it. Update: Now is working |
* master: (41 commits) Add Coretime to Westend (#3319) removed `pallet::getter` from `pallet-sudo` (#3370) gossip-support: add unittests for update authorities (#3258) [FRAME Core] remove unnecessary overrides while using derive_impl for frame_system (#3317) Update coretime-westend bootnodes (#3380) `im-online` removal cleanup: remove off-chain storage (#2290) Bump the known_good_semver group with 1 update (#3379) Fix documentation dead link (#3372) Make `sp-keystore` `no_std`-compatible and fix the `build-runtimes-polkavm` CI job (#3363) Remove unused `im-online` weights (#3373) Ensure referenda `TracksInfo` is sorted (#3325) rpc server: add rate limiting middleware (#3301) do not block finality for "disabled" disputes (#3358) fix(zombienet): docker `img` version to use in merge queues for bridges (#3337) Various nits and alignments for SP testnets found during bumping `polkadot-fellows` repo (#3359) Add broker pallet to `coretime-westend` (#3272) remove recursion limit (#3348) Update subkey README.md (#3355) Bump the known_good_semver group with 6 updates (#3347) Document LocalKeystore insert method (#3336) ...
Fix image tag to use in merge queues tests, currently is failing because is using the wrong tag (e.g https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5224342).
Thx!