Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet-membership weights #3324

Merged
merged 11 commits into from
Feb 23, 2024
Merged

pallet-membership weights #3324

merged 11 commits into from
Feb 23, 2024

Conversation

Dinonard
Copy link
Contributor

Summary

  • use benchamarked weights instead of hardcoded ones for pallet-membership
  • rename benchmark to match extrinsic name
  • remove unnecessary dependency from clear_prime

@Dinonard Dinonard requested a review from a team as a code owner February 14, 2024 13:08
ggwpez
ggwpez reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😅

substrate/frame/membership/src/lib.rs Show resolved Hide resolved
substrate/frame/membership/src/migrations/v4.rs Outdated Show resolved Hide resolved
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 14, 2024 15:03
bkchr
bkchr approved these changes Feb 14, 2024
View reviewed changes
substrate/frame/membership/src/lib.rs Outdated Show resolved Hide resolved
@Dinonard
Copy link
Contributor Author

Can this be merged or is there something else I should do?

@ggwpez ggwpez added R0-silent Changes should not be mentioned in any release notes and removed R0-silent Changes should not be mentioned in any release notes labels Feb 19, 2024
@ggwpez
Add prdoc
5f4a9de 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez enabled auto-merge February 19, 2024 18:00
@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Feb 19, 2024
@ggwpez ggwpez added this pull request to the merge queue Feb 23, 2024
Merged via the queue into paritytech:master with commit 5fc6d67 Feb 23, 2024
122 of 129 checks passed
@Dinonard Dinonard deleted the dinonard/pallet-membership-weights branch February 23, 2024 14:33
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@Dinonard @ggwpez
pallet-membership weights (paritytech#3324)
b3b7fdb 
## Summary
* use benchamarked weights instead of hardcoded ones for
`pallet-membership`
* rename benchmark to match extrinsic name
* remove unnecessary dependency from `clear_prime`

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinonard @bkchr @ggwpez