Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts: Refactor API to use WeightMeter #2943

Merged
merged 22 commits into from
Apr 9, 2024
Merged

Contracts: Refactor API to use WeightMeter #2943

merged 22 commits into from
Apr 9, 2024

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Jan 16, 2024 •
edited
Loading

Update the Contracts API to use WeightMeter, as it simplifies the code and makes it easier to reason about, rather than taking a mutable weight or returning a tuple with the weight consumed

@pgherveou pgherveou requested a review from athei as a code owner January 16, 2024 12:31
@pgherveou pgherveou requested a review from a team January 16, 2024 12:31
@pgherveou pgherveou changed the base branch from master to pg/contracts-charge-min-amount-when-processing-deletion-queue January 16, 2024 12:31
@pgherveou
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Jan 16, 2024 •
edited
Loading

@pgherveou "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4930647) was cancelled in #2943 (comment)

@pgherveou pgherveou added the R0-silent Changes should not be mentioned in any release notes label Jan 16, 2024
@pgherveou
Copy link
Contributor Author

bot cancel

@command-bot
Copy link

command-bot bot commented Jan 16, 2024

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4930647 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4930647/artifacts/download.

@pgherveou
Copy link
Contributor Author

@athei added some quick cleanup here, can you take a look when you have a chance

athei
athei reviewed Jan 26, 2024
View reviewed changes
substrate/frame/contracts/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/contracts/src/migration.rs Outdated Show resolved Hide resolved
substrate/frame/contracts/src/migration.rs Outdated Show resolved Hide resolved
substrate/frame/contracts/src/storage.rs Show resolved Hide resolved
Base automatically changed from pg/contracts-charge-min-amount-when-processing-deletion-queue to master March 6, 2024 08:53
@pgherveou
Copy link
Contributor Author

@athei completely missed your review here, will address the comments

@athei athei enabled auto-merge April 9, 2024 09:59
@athei athei added this pull request to the merge queue Apr 9, 2024
Merged via the queue into master with commit b6231c7 Apr 9, 2024
107 of 135 checks passed
@athei athei deleted the pg/use-weightmeter branch April 9, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xermicus xermicus xermicus approved these changes

@athei athei athei approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgherveou @athei @xermicus