Remove kusama and polkadot SP constants from parachains-common #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadanda
added
the
T14-system_parachains
bkchr
approved these changes
Dec 18, 2023
acatangiu
approved these changes
Dec 18, 2023
bkontur
approved these changes
Dec 21, 2023
liamaharon
approved these changes
Dec 21, 2023
gupnik
approved these changes
Dec 22, 2023
gpestana
approved these changes
Jan 4, 2024
Co-authored-by: Gonçalo Pestana <[email protected]>
ggwpez
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Merge after polkadot-fellows/runtimes#115
We can also merge this ahead, since we use crates-io in the runtimes.
bkchr
added a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Jan 4, 2024
This PR brings the Kusama and Polkadot constants for System Parachains into the control of the Fellowship. Following up on paritytech/polkadot-sdk#2620 and paired with paritytech/polkadot-sdk#2666. Types are still used from the `parachains-common` crate, but constants are moved into a new crate `system-parachains-constants` in this repo. The re-exports `pub use parachains_common as common` in both asset hubs and collectives have been removed. This is a breaking change for anybody using them in this way, but these should be directly imported from `parachains-common`. This should be noted on the changelog. --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2620 and partnered with polkadot-fellows/runtimes#115
Merge after polkadot-fellows/runtimes#115