Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ParentOrSiblings #2428

Merged
merged 16 commits into from
Dec 12, 2023
Merged

Fix ParentOrSiblings #2428

merged 16 commits into from
Dec 12, 2023

Conversation

franciscoaguirre
Copy link
Contributor

We were not filtering for sibling parachains, but for sibling anything

@paritytech-review-bot paritytech-review-bot bot requested review from a team November 21, 2023 15:34
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Nov 21, 2023
@franciscoaguirre franciscoaguirre added the R0-silent Changes should not be mentioned in any release notes label Nov 21, 2023
This was referenced Nov 30, 2023
Merged
Closed
@bkontur
Copy link
Contributor

bkontur commented Nov 30, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Nov 30, 2023 •
edited
Loading

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4557170 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 19-7eae007e-906a-422f-be34-a03a3b853f8f to cancel this command or bot cancel to cancel all commands in this pull request.

muharem
muharem approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@muharem muharem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer such configs to be located within the runtime crate, not in common.

@command-bot
Copy link

command-bot bot commented Nov 30, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4557170 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4557170/artifacts/download.

@franciscoaguirre
Copy link
Contributor Author

It's in common just because it's a configuration that is common to all our runtimes, as a way of deduplicating code

@franciscoaguirre franciscoaguirre enabled auto-merge (squash) November 30, 2023 13:15
@paritytech-review-bot paritytech-review-bot bot requested review from a team December 6, 2023 15:41
@franciscoaguirre franciscoaguirre requested review from a team December 9, 2023 18:47
@franciscoaguirre franciscoaguirre requested a review from a team December 9, 2023 18:47
@franciscoaguirre franciscoaguirre requested review from koute and a team as code owners December 9, 2023 18:47
@franciscoaguirre
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 10, 2023 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4675696 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-2ae3e6c4-e154-4351-91c8-284f6dcd8c9c to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 10, 2023

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4675696 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4675696/artifacts/download.

@franciscoaguirre franciscoaguirre merged commit 313b2c4 into master Dec 12, 2023
113 of 115 checks passed
@franciscoaguirre franciscoaguirre deleted the cis-parent-or-siblings branch December 12, 2023 16:36
@bkontur bkontur mentioned this pull request Dec 18, 2023
Merged
3 tasks
bkontur added a commit to bkontur/runtimes that referenced this pull request Feb 15, 2024
@bkontur
[xcm] adapt paritytech/polkadot-sdk#2428 (ParentRelayOrSiblingParacha…
a29757d 
…ins)
bkontur added a commit to bkontur/runtimes that referenced this pull request Feb 16, 2024
@bkontur
[xcm] adapt paritytech/polkadot-sdk#2428 (ParentRelayOrSiblingParacha…
44eefcc 
…ins)
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jun 25, 2024
@AurevoirXavier
paritytech/polkadot-sdk#2428
b1d1ca6
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jun 28, 2024
@AurevoirXavier @boundless-forest
To polkadot-v1.7.2 (#1516)
61e127a 
* Setup deps

* Remove Koi from account migration test

* paritytech/polkadot-sdk#1495

* Bump

* paritytech/polkadot-sdk#1524

* !! paritytech/polkadot-sdk#1363

* paritytech/polkadot-sdk#1492

* paritytech/polkadot-sdk#1911

* paritytech/polkadot-sdk#1900

Signed-off-by: Xavier Lau <[email protected]>

* paritytech/polkadot-sdk#1661

* paritytech/polkadot-sdk#2144

* paritytech/polkadot-sdk#2048

* paritytech/polkadot-sdk#1672

* paritytech/polkadot-sdk#2303

* paritytech/polkadot-sdk#1256

* Remove identity and vesting

* Fixes

* paritytech/polkadot-sdk#2657

* paritytech/polkadot-sdk#1313

* paritytech/polkadot-sdk#2331

* paritytech/polkadot-sdk#2409 part.1

* paritytech/polkadot-sdk#2767

* paritytech/polkadot-sdk#2521

Signed-off-by: Xavier Lau <[email protected]>

* paritytech/polkadot-sdk#1222

* paritytech/polkadot-sdk#1234 part.1

* Satisfy compiler

* XCM V4 part.1

* paritytech/polkadot-sdk#1246

* Remove pallet-democracy part.1

* paritytech/polkadot-sdk#2142

* paritytech/polkadot-sdk#2428

* paritytech/polkadot-sdk#3228

* XCM V4 part.2

* Bump

* Build all runtimes

* Build node

* Remove pallet-democracy

Signed-off-by: Xavier Lau <[email protected]>

* Format

* Fix pallet tests

* Fix precompile tests

* Format

* Fixes

* Async, remove council, common pallet config

* Fix `ethtx-forward` test case (#1519)

* Fix ethtx-forward tests

* Format

* Fix following the review

* Fixes

* Fixes

* Use default impl

* Benchmark helper

* Bench part.1

* Bench part.2

* Bench part.3

* Fix all tests

* Typo

* Feat

* Fix EVM tracing build

* Reuse upstream `proof_size_base_cost()` (#1521)

* Format issue

* Fixes

* Fix CI

---------

Signed-off-by: Xavier Lau <[email protected]>
Co-authored-by: Bear Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepetrowski joepetrowski joepetrowski approved these changes

@rphmeier rphmeier rphmeier left review comments

@acatangiu acatangiu acatangiu approved these changes

@bkontur bkontur bkontur approved these changes

@muharem muharem muharem approved these changes

@bkchr bkchr bkchr approved these changes

@gavofyork gavofyork Awaiting requested review from gavofyork

@athei athei Awaiting requested review from athei

@andresilva andresilva Awaiting requested review from andresilva

@jsidorenko jsidorenko Awaiting requested review from jsidorenko

@koute koute Awaiting requested review from koute

Assignees

@franciscoaguirre franciscoaguirre

Labels
R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@franciscoaguirre @bkontur @bkchr @muharem @rphmeier @joepetrowski @acatangiu