Give up liveness slashing #2254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Nov 9, 2023
s0me0ne-unkn0wn
added
the
T2-pallets
eskimor
approved these changes
Nov 9, 2023
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
I don't get why we need this pr. Why are we not just remove the pallet from the runtime? |
I will adhere to this. Do we really need to change this pallet functionality for a particular use case that can be achieved by just not using it? |
|
Yeah. I also don't like this and I really don't see any reason. I'm going to close this for the other pr that just removes the stuff. |
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with #1964, we give up liveness slashing. The first step is to always return zero offense threshold. This will be followed up by removing the
im-onlinepallet entirely.