-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove (rococo/westend)-runtime
deps from testnet AssetHubs
#1979
Conversation
bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_relayers |
@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4043483 was started for your command Comment |
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/xcm_config.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Edit: query has already been resolved.
…=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers
@bkontur Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty!
…r XcmFeeManager and paritytech/polkadot-sdk#1979) + moved tests to separate file
Problem
This PR addresses the issue with testnet AssetHub builds, which was discovered during the execution of
bot bench
.https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038738
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038739
Solution
rococo-runtime
andwestend-runtime
introduced by this PR.<rococo_runtime::Treasury as PalletInfoAccess>::index()
withrococo_runtime_constants::TREASURY_PALLET_ID
.check_treasury_pallet_id
to the relay runtimes to ensure that the constant is aligned with the pallet id.BridgeHubRococo
(to be aligned with AssetHubs).References
Full element discussion here.