Add UMP pricing #1556

franciscoaguirre · 2023-09-14T04:27:09Z

Description

Adds pricing for UMP, much like it was added for DMP in paritytech/polkadot#6843 and HRMP in #1234.

This means all system parachains now charge for fees when sending messages to the relay chain.

Note for reviewers

Most changed files are tests, the most relevant files are:

cumulus/pallets/parachain-system/src/lib.rs <- ParachainSystem pallet now tracks the exponential factor for the delivery fees
All the xcm_config files <- They add PriceForParentDelivery as the price on the ParentAsUmp router

TODO

Track fee in ParachainSystem
Add ExponentialPrice in UMP router in configs

franciscoaguirre · 2023-09-14T23:51:03Z

bot fmt

command-bot · 2023-09-14T23:51:08Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3703290 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-b5f3fa31-1b83-47e7-a4a9-662f186abf59 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-09-14T23:54:01Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3703290 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3703290/artifacts/download.

cumulus/pallets/parachain-system/src/lib.rs

Co-authored-by: Keith Yeung <[email protected]>

franciscoaguirre · 2023-10-11T13:01:50Z

bot fmt

command-bot · 2023-10-11T13:01:55Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3934681 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 25-20a11ff4-4977-48ca-86d1-b6fd7208bfe3 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-11T13:04:01Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3934681 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3934681/artifacts/download.

franciscoaguirre · 2023-10-11T14:37:18Z

bot fmt

command-bot · 2023-10-11T14:37:24Z

"$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" was queued.

Comment bot cancel 28-e82069ed-ffc9-4540-b445-7965380e1538 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-11T14:37:37Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

franciscoaguirre · 2023-10-11T14:40:43Z

bot fmt

command-bot · 2023-10-11T14:40:48Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3937649 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 30-562fc6c2-e7f3-4c72-bd49-fadf5893083a to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-11T14:41:49Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3937649 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3937649/artifacts/download.

paritytech-cicd-pr · 2023-10-12T09:14:42Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3945768

franciscoaguirre · 2023-10-12T12:40:44Z

bot fmt

command-bot · 2023-10-12T12:40:49Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3948850 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 33-107841bd-4bcf-4a3d-a054-8b2cb5483f41 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-12T12:44:16Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3948850 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3948850/artifacts/download.

xlc · 2023-10-12T21:35:22Z

Can someone write some explanations so I don't need to read all the code to understand exactly the impact of this?
How does this impact users of system parachains? Will they be charged additional fees for some actions?
How does this impact parachains teams? Any recommendations of the parameters?
How does this impact UI devs? How do they query/estimate the fees to show the fees to users?

…paste` dependency everywhere (#1556) * Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere * Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis

Add relay in possible destinations for fee factor

028286b

franciscoaguirre changed the base branch from master to kckyeung/xcm-fees-manager September 14, 2023 04:27

franciscoaguirre changed the title ~~Cis ump pricing~~ Add UMP pricing Sep 14, 2023

KiChjang force-pushed the kckyeung/xcm-fees-manager branch from 6005ef1 to ca69936 Compare September 14, 2023 05:30

franciscoaguirre added 5 commits September 14, 2023 16:11

Add associated type to FeeTracker

9384e68

Add delivery fe calculation to ParachainSystem

69f1c52

Increase delivery fee when sending a message

4d7b6be

Refactor threshold function

72151bf

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

223d878

".git/.scripts/commands/fmt/fmt.sh"

9988073

franciscoaguirre self-assigned this Sep 15, 2023

franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Sep 15, 2023

franciscoaguirre added 3 commits September 14, 2023 21:24

Fix TestFeeTracker

fea53ba

Fix UMP ExponentialPrice for asset hub kusama

1928602

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

f6a8c0e

KiChjang reviewed Sep 18, 2023

View reviewed changes

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

KiChjang reviewed Sep 18, 2023

View reviewed changes

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

KiChjang reviewed Sep 18, 2023

View reviewed changes

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

franciscoaguirre and others added 9 commits September 26, 2023 20:51

Update cumulus/pallets/parachain-system/src/lib.rs

6e11751

Co-authored-by: Keith Yeung <[email protected]>

Update cumulus/pallets/parachain-system/src/lib.rs

d4b1ae2

Co-authored-by: Keith Yeung <[email protected]>

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

b1e16f6

Fix type issues

6f6b0fa

Remove one-liner function

27c9216

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

0b6f8b8

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

c259315

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

2f95d72

Change xcm delivery fee helpers to work with UMP

5bc24da

".git/.scripts/commands/fmt/fmt.sh"

94ba563

franciscoaguirre added 3 commits October 11, 2023 16:31

Waive delivery fees for westend treasury location

324c20f

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

38b7dfd

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

6bd03ba

".git/.scripts/commands/fmt/fmt.sh"

551e2f6

franciscoaguirre added 5 commits October 11, 2023 17:53

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

bc5c9c6

Merge branch 'kckyeung/xcm-fees-manager' into cis-ump-pricing

c2ba081

Fix feature propagation

9b5fc15

Fix feature propagation

20bd27f

Fix fmt manifest

a172a7c

Remove unused things

87c7158

franciscoaguirre merged commit 73ad0fc into kckyeung/xcm-fees-manager Oct 12, 2023
6 of 7 checks passed

franciscoaguirre deleted the cis-ump-pricing branch October 12, 2023 13:22

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add UMP pricing #1556

Add UMP pricing #1556

franciscoaguirre commented Sep 14, 2023 •

edited

Loading

franciscoaguirre commented Sep 14, 2023

command-bot bot commented Sep 14, 2023 •

edited

Loading

command-bot bot commented Sep 14, 2023

franciscoaguirre commented Oct 11, 2023

command-bot bot commented Oct 11, 2023 •

edited

Loading

command-bot bot commented Oct 11, 2023

franciscoaguirre commented Oct 11, 2023

command-bot bot commented Oct 11, 2023 •

edited

Loading

command-bot bot commented Oct 11, 2023

franciscoaguirre commented Oct 11, 2023

command-bot bot commented Oct 11, 2023 •

edited

Loading

command-bot bot commented Oct 11, 2023

paritytech-cicd-pr commented Oct 12, 2023

franciscoaguirre commented Oct 12, 2023

command-bot bot commented Oct 12, 2023 •

edited

Loading

command-bot bot commented Oct 12, 2023

xlc commented Oct 12, 2023

Add UMP pricing #1556

Add UMP pricing #1556

Conversation

franciscoaguirre commented Sep 14, 2023 • edited Loading

Description

Note for reviewers

TODO

franciscoaguirre commented Sep 14, 2023

command-bot bot commented Sep 14, 2023 • edited Loading

command-bot bot commented Sep 14, 2023

franciscoaguirre commented Oct 11, 2023

command-bot bot commented Oct 11, 2023 • edited Loading

command-bot bot commented Oct 11, 2023

franciscoaguirre commented Oct 11, 2023

command-bot bot commented Oct 11, 2023 • edited Loading

command-bot bot commented Oct 11, 2023

franciscoaguirre commented Oct 11, 2023

command-bot bot commented Oct 11, 2023 • edited Loading

command-bot bot commented Oct 11, 2023

paritytech-cicd-pr commented Oct 12, 2023

franciscoaguirre commented Oct 12, 2023

command-bot bot commented Oct 12, 2023 • edited Loading

command-bot bot commented Oct 12, 2023

xlc commented Oct 12, 2023

franciscoaguirre commented Sep 14, 2023 •

edited

Loading

command-bot bot commented Sep 14, 2023 •

edited

Loading

command-bot bot commented Oct 11, 2023 •

edited

Loading

command-bot bot commented Oct 11, 2023 •

edited

Loading

command-bot bot commented Oct 11, 2023 •

edited

Loading

command-bot bot commented Oct 12, 2023 •

edited

Loading