Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable validation/collation v2 protocols #1542

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Enable validation/collation v2 protocols #1542

merged 6 commits into from
Sep 15, 2023

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Sep 13, 2023 •
edited
Loading

Removes the network-protocol-staging feature. This is needed for the first release of async backing capable nodes.
Renames VStaging to V2
on top of #1543

@sandreim sandreim added T0-node This PR/Issue is related to the topic “node”. T9-parachains_protocol labels Sep 13, 2023
@sandreim
Copy link
Contributor Author

It makes sense to wait merging #1543 first.

@sandreim sandreim changed the base branch from master to slumber-async-backing-v6-primitives September 14, 2023 12:24
@sandreim sandreim force-pushed the sandreim/network_protocol_v2 branch from b83a019 to 8bf3cfe Compare September 14, 2023 12:26
@sandreim
rename batch 1
5a97e72 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
rename and fmt
a04d6ce 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
remove stray v5
f8caa3a 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim sandreim requested review from ordian and slumber September 14, 2023 12:46
@sandreim
review
9898795 
Signed-off-by: Andrei Sandu <[email protected]>
ordian
ordian approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this won't break Rococo and Westend 😅

@sandreim
Copy link
Contributor Author

I hope this won't break Rococo and Westend 😅

we could do a burn-in to be sure :)

@sandreim sandreim requested a review from slumber September 14, 2023 14:44
@Sophia-Gold Sophia-Gold mentioned this pull request Sep 15, 2023
Closed
@sandreim sandreim merged commit 4cb5e35 into slumber-async-backing-v6-primitives Sep 15, 2023
6 checks passed
@sandreim sandreim deleted the sandreim/network_protocol_v2 branch September 15, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slumber slumber slumber approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandreim @ordian @slumber