Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable async backing on Rococo #1496

Closed
wants to merge 1 commit into from
Closed

Enable async backing on Rococo #1496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions polkadot/runtime/rococo/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1714,6 +1714,7 @@ sp_api::impl_runtime_apis! {
}
}

#[api_version(99)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem. We can not have a release with version 99. We have to pick a proper version, which has consequences (which should be fine): We have to release this API next in production. We can then no longer release any other new functionality without also releasing async backing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more correct: We have to determine now what the next version is exactly. By making it no longer 99, this version is stable and must no longer be changed/modified in any way without bumping the version again.

Copy link
Contributor

@rphmeier rphmeier Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we need is a way to stabilize the API version without automatically upgrading all runtimes to it

impl primitives::runtime_api::ParachainHost<Block, Hash, BlockNumber> for Runtime {
fn validators() -> Vec<ValidatorId> {
parachains_runtime_api_impl::validators::<Runtime>()
Expand Down Expand Up @@ -1844,6 +1845,14 @@ sp_api::impl_runtime_apis! {
key_ownership_proof,
)
}

fn staging_para_backing_state(para_id: ParaId) -> Option<primitives::vstaging::BackingState> {
runtime_parachains::runtime_api_impl::vstaging::backing_state::<Runtime>(para_id)
}

fn staging_async_backing_params() -> primitives::vstaging::AsyncBackingParams {
runtime_parachains::runtime_api_impl::vstaging::async_backing_params::<Runtime>()
}
}

#[api_version(3)]
Expand Down