Implements partial inflation minting to treasury #1483

gpestana · 2023-09-11T01:12:58Z

This PR implements an optional minting of the inflation directly into a pot.

The staking pallet now has a percent storage item, InflationLevyFraction, which defines the percentage of the era inflation that should be minted directly into an account (the treasury's account). The remaining of the fraction is the validators rewards for that era. The InflationLevyFraction can be set via extrinsic by the staking admin origin through the set_treasury_fraction callable. The InflationLevyFraction default is 0.

Treasury `Get<AccountId>` implementation

This PR also implements the Get<AccountId> in the treasury pallet which exposes an account id derived at the origin. This helps the staking pallet to request the account ID of the treasury pallet, instead of deriving it locally based on its pallet ID.

Closes #403

gpestana · 2023-09-11T12:28:53Z

bot bench substrate-pallet --pallet=pallet_staking

gpestana · 2023-09-11T12:30:54Z

bot help

…nto HEAD

…=dev --target_dir=substrate --pallet=pallet_staking

gpestana · 2023-09-11T14:51:10Z

bot bench polkadot-pallet --runtime polkadot

gpestana · 2023-09-11T14:53:12Z

bot bench polkadot-pallet --pallet=pallet_staking --runtime polkadot

gpestana · 2023-09-11T18:05:19Z

bot clean

substrate/frame/staking/src/pallet/mod.rs

kianenigma

Somewhat skeptical of this implementation being in the right path.

Staking already have a way to communicate "what should I do with the rest of my rewards?", which is RewardRemainder.

It seems a bit sloppy to add another similar mechanism that says "before I distribute my rewards, what should I do with it?".

I kinda wish there was a way to reuse RewardRemainder to bundle it into a single new hook that expresses what should be done with rewards.

Lastly, you are making a few important assumptions:

That a treasury pallet exists.
How this treasury pallet's pallet id should be converted into an account id.

Ideally, all of this should be more abstract.

…unt id

gpestana · 2023-09-13T10:14:51Z

Staking already have a way to communicate "what should I do with the rest of my rewards?", which is RewardRemainder.

My idea is that the treasury payment and validator rewards are both first citizen reward "receivers", thus there could be still a remainder. I will look into this direction again though.

Ideally, all of this should be more abstract.

Good point, I think that there are a few things that could be changed: 1) renaming "TreasuryPot" to something else, 2) have a way to request the account ID of a type that implements a new Pot trait that exposes a way to get an account_id. This last point is already implemented in the last commit.

Using the trait Pot also helps making the implementation safer, since it offloads the burden of deriving the account ID to the origin so that we don't need to keep the account ID derivation in 2 different places, which may be error-prone in case of updates.

EDIT: instead of creating a new Pot trait, the PR is using the Get<AccountId> instead, which is implemented by the treasury pallet.

gpestana · 2023-09-14T14:00:05Z

bot fmt

command-bot · 2023-09-14T14:00:10Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3697257 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-a5d29906-5be9-4931-8af1-42a711901856 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-09-14T14:03:03Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3697257 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3697257/artifacts/download.

gpestana · 2023-09-18T12:30:09Z

Staking already have a way to communicate "what should I do with the rest of my rewards?", which is RewardRemainder.

My idea is that the treasury payment and validator rewards are both first citizen reward "receivers", thus there could be still a remainder. I will look into this direction again though.

Ideally, all of this should be more abstract.

Good point, I think that there are a few things that could be changed: 1) renaming "TreasuryPot" to something else, 2) have a way to request the account ID of a type that implements a new Pot trait that exposes a way to get an account_id. This last point is already implemented in the last commit.

Using the trait Pot also helps making the implementation safer, since it offloads the burden of deriving the account ID to the origin so that we don't need to keep the account ID derivation in 2 different places, which may be error-prone in case of updates.

EDIT: instead of creating a new Pot trait, the PR is using the Get<AccountId> instead, which is implemented by the treasury pallet.

gpestana · 2023-09-18T12:37:45Z

@kianenigma to touch base on your comment to abstract this further and use the RewardRemainder as a way to pay the treasury fraction:

My current perspective is that the RewardRemainder should be the remainder of the total payout (validator rewards and treasury %), based on the yearly inflation and the total payouts.

Following that, I think that having an explicit InflationLevyFraction and InflationLevyDestination = Get<AccountId>, and explicitly use those types to calculate and mint directly into the treasury is a reasonable way to implement this. wdyt?

Otoh, we could refactor the way we handle the reward remainder and RewardRemainder to both handle the inflation remainder and the treasury payment, but I think that's not conceptually the best way (i.e. the treasury payout is not a "remainder").

gpestana · 2023-09-21T09:26:04Z

Being replaced by #1660

This PR implements an (optional) cap of the era inflation that is allocated to staking rewards. The remaining is minted directly into the [`RewardRemainder`](https://github.com/paritytech/polkadot-sdk/blob/fb0fd3e62445eb2dee2b2456a0c8574d1ecdcc73/substrate/frame/staking/src/pallet/mod.rs#L160) account, which is the treasury pot account in Polkadot and Kusama. The staking pallet now has a percent storage item, `MaxStakersRewards`, which defines the max percentage of the era inflation that should be allocated to staking rewards. The remaining era inflation (i.e. `remaining = max_era_payout - staking_payout.min(staking_payout * MaxStakersRewards))` is minted directly into the treasury. The `MaxStakersRewards` can be set by a privileged origin through the `set_staking_configs` extrinsic. **To finish** - [x] run benchmarks for westend-runtime Replaces #1483 Closes #403 --------- Co-authored-by: command-bot <>

…#1660) This PR implements an (optional) cap of the era inflation that is allocated to staking rewards. The remaining is minted directly into the [`RewardRemainder`](https://github.com/paritytech/polkadot-sdk/blob/d349b45d086199af7ad0195534e2b913ba9b6827/substrate/frame/staking/src/pallet/mod.rs#L160) account, which is the treasury pot account in Polkadot and Kusama. The staking pallet now has a percent storage item, `MaxStakersRewards`, which defines the max percentage of the era inflation that should be allocated to staking rewards. The remaining era inflation (i.e. `remaining = max_era_payout - staking_payout.min(staking_payout * MaxStakersRewards))` is minted directly into the treasury. The `MaxStakersRewards` can be set by a privileged origin through the `set_staking_configs` extrinsic. **To finish** - [x] run benchmarks for westend-runtime Replaces paritytech#1483 Closes paritytech#403 --------- Co-authored-by: command-bot <>

Unify the operating mode for bridge pallets - define the OperationMode trait and BasicOperatingMode enum - use the OperationMode trait in all the bridge pallets - use BasicOperatingMode instead of IsHalted for the Grandpa pallet - use BasicOperatingMode as part of MessagesOperatingMode Signed-off-by: Serban Iorga <[email protected]>

Implements partial inflation minting to treasury

fcbb925

gpestana requested a review from Ank4n September 11, 2023 01:13

gpestana self-assigned this Sep 11, 2023

gpestana requested review from kianenigma and jakoblell September 11, 2023 01:14

gpestana removed the T5-host_functions This PR/Issue is related to host functions. label Sep 11, 2023

gpestana added 2 commits September 11, 2023 10:56

Adds set treasury fraction tests

1685ac8

Fixes runtimes

ff250f7

gpestana requested review from a team September 11, 2023 09:47

Fixes runtimes v2

e7a3c08

gpestana requested review from acatangiu and andresilva as code owners September 11, 2023 10:24

gpestana requested a review from a team September 11, 2023 10:24

gpestana added 3 commits September 11, 2023 12:36

Fixes benchmarks

831afa2

Fixes benchmarks v2

488ed0d

Fixes benchmarks

f3b437f

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

d1ea02c

…nto HEAD

jonasW3F mentioned this pull request Sep 11, 2023

Add Dispatchable Interface for Staking's reward_by_ids and report_offence #1481

Open

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

f07f277

…=dev --target_dir=substrate --pallet=pallet_staking

gpestana removed the request for review from jakoblell September 11, 2023 14:34

franciscoaguirre reviewed Sep 11, 2023

View reviewed changes

substrate/frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved

substrate/frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved

substrate/frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved

kianenigma reviewed Sep 13, 2023

View reviewed changes

Adds Pot trait and uses it in staking to fetch the treasury pot acco…

5de3dc2

…unt id

Addresses PR review comments

b103f2d

gpestana requested a review from franciscoaguirre September 13, 2023 10:21

gpestana added 2 commits September 13, 2023 22:00

Refactor to more abstracted treasury levy in era rewards

8836a80

Replaces the trait Pot with Get<AccountId>

a71bd2a

".git/.scripts/commands/fmt/fmt.sh"

db67906

gpestana requested a review from kianenigma September 14, 2023 14:05

gpestana closed this Sep 18, 2023

gpestana reopened this Sep 18, 2023

gpestana added 2 commits September 18, 2023 14:39

Updates documentation

0721cb9

Merge branch 'master' into gpestana/403-treasury_mint

1ca092a

gpestana mentioned this pull request Sep 21, 2023

Implements a % cap on staking rewards from era inflation #1660

Merged

1 task

gpestana closed this Sep 21, 2023

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implements partial inflation minting to treasury #1483

Implements partial inflation minting to treasury #1483

gpestana commented Sep 11, 2023 •

edited

Loading

gpestana commented Sep 11, 2023

gpestana commented Sep 11, 2023

gpestana commented Sep 11, 2023

gpestana commented Sep 11, 2023

gpestana commented Sep 11, 2023

kianenigma left a comment

gpestana commented Sep 13, 2023 •

edited

Loading

gpestana commented Sep 14, 2023

command-bot bot commented Sep 14, 2023 •

edited

Loading

command-bot bot commented Sep 14, 2023

gpestana commented Sep 18, 2023 •

edited

Loading

gpestana commented Sep 18, 2023

gpestana commented Sep 21, 2023

Implements partial inflation minting to treasury #1483

Implements partial inflation minting to treasury #1483

Conversation

gpestana commented Sep 11, 2023 • edited Loading

Treasury Get<AccountId> implementation

gpestana commented Sep 11, 2023

gpestana commented Sep 11, 2023

gpestana commented Sep 11, 2023

gpestana commented Sep 11, 2023

gpestana commented Sep 11, 2023

kianenigma left a comment

Choose a reason for hiding this comment

gpestana commented Sep 13, 2023 • edited Loading

gpestana commented Sep 14, 2023

command-bot bot commented Sep 14, 2023 • edited Loading

command-bot bot commented Sep 14, 2023

gpestana commented Sep 18, 2023 • edited Loading

gpestana commented Sep 18, 2023

gpestana commented Sep 21, 2023

gpestana commented Sep 11, 2023 •

edited

Loading

Treasury `Get<AccountId>` implementation

gpestana commented Sep 13, 2023 •

edited

Loading

command-bot bot commented Sep 14, 2023 •

edited

Loading

gpestana commented Sep 18, 2023 •

edited

Loading