Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve docs]: Timestamp pallet #1435

Merged
merged 18 commits into from
Sep 18, 2023
Merged

[improve docs]: Timestamp pallet #1435

merged 18 commits into from
Sep 18, 2023

Conversation

sacha-l
Copy link
Contributor

@sacha-l sacha-l commented Sep 6, 2023

This PR improves the docs for the Timestamp pallet by following our Documentation Guidelines more closely.

Sacha Lansky added 3 commits September 6, 2023 18:15
@sacha-l sacha-l added the T11-documentation This PR/Issue is related to documentation. label Sep 6, 2023
@paritytech-ci paritytech-ci requested a review from a team September 6, 2023 22:35
proc macro crate, but often will no longer function when these proc macros are re-exported elsewhere in your project.
The exception is doc links to _other proc macros_ which will function just fine if they are also being re-exported. It
The exception is doc links to *other proc macros* which will function just fine if they are also being re-exported. It
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why the preference of * over _

Copy link
Contributor Author

@sacha-l sacha-l Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about a particular reason but it's defined in: https://github.com/paritytech/polkadot-sdk/blob/master/.github/.markdownlint.yaml

@paritytech-ci paritytech-ci requested a review from a team September 8, 2023 07:43
@paritytech-ci paritytech-ci requested a review from a team September 8, 2023 07:46
@paritytech-ci paritytech-ci requested a review from a team September 8, 2023 07:47
substrate/frame/timestamp/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/timestamp/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/timestamp/src/lib.rs Outdated Show resolved Hide resolved
@sacha-l sacha-l requested a review from a team September 11, 2023 13:56
Sacha Lansky and others added 3 commits September 11, 2023 16:00
@sacha-l sacha-l enabled auto-merge (squash) September 18, 2023 08:24
@sacha-l sacha-l merged commit f6072e8 into master Sep 18, 2023
6 checks passed
@sacha-l sacha-l deleted the sl/timestamp-pallet-refactor branch September 18, 2023 09:09
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
This PR improves the docs for the Timestamp pallet by following our
[Documentation
Guidelines](https://github.com/paritytech/polkadot-sdk/blob/master/docs/DOCUMENTATION_GUIDELINE.md)
more closely.

---------

Co-authored-by: Juan <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T11-documentation This PR/Issue is related to documentation.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants