allow governance body on parachain to have sovereign account #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
the
T8-polkadot
franciscoaguirre
approved these changes
Aug 30, 2023
KiChjang
approved these changes
Aug 30, 2023
|
Anyone want to hit the merge button? It won't kill you. |
|
This still requires an audit before we can merge/release. |
ok. that’s fine. is there a label to indicate that? |
|
Not that I know of; someone from devops should look into this, perhaps @the-right-joyce? |
|
labels are not any longer used for the auditing process. Instead PRs should be added to the security audit board as mentioned here I see that your PR was archived though, will check with SRLabs and come back to you |
|
@KiChjang it was already audited, we can merge |
KiChjang
approved these changes
Sep 19, 2023
ggwpez
reviewed
Jan 30, 2024
| @@ -68,6 +68,8 @@ pub type SovereignAccountOf = ( | |||
| ChildParachainConvertsVia<ParaId, AccountId>, | |||
| // We can directly alias an `AccountId32` into a local account. | |||
| AccountId32Aliases<ThisNetwork, AccountId>, | |||
| // Allow governance body to be used as a sovereign account. | |||
| HashedDescription<AccountId, DescribeFamily<DescribeBodyTerminal>>, | |||
fellowship-merge-bot bot
added a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Feb 2, 2024
We imported the runtimes into this repo at tag [`v1.1.0-rc2`](https://github.com/paritytech/polkadot-sdk/commits/v1.1.0-rc2/) but still merged stuff until they got removed in [#1731](paritytech/polkadot-sdk#1731). This re-applies all changes in that commit range [`v1.1.0-rc2..bf90cb0b`](paritytech/polkadot-sdk@v1.1.0-rc2...bf90cb0) checked in the SDK with `git log v1.1.0-rc2..bf90cb0b -- polkadot/runtime/`. Closes #112 Most changes got applied as part of #56, but two were missing: - paritytech/polkadot-sdk#1303 - <s>https://github.com/paritytech/polkadot-sdk/pull/1476</s> (reverted) <s>One [open Q](#67 (comment)) since there was a difference between [#1291](paritytech/polkadot-sdk#1291) and #67.</s> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: joe petrowski <[email protected]>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* relay balance metrics * convert balance to "main" tokens in balance metrics * add balances widgets to maintenance dashboard
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to allow Fellowship on Collective chain to have a sovereign account on Polkadot so that we can add it as an identity registrar. This will allow Fellows origin to be able to provide judgements for Fellowship members.
This currently allow any body on any parachain including non system parachains to have sovereign account. I cannot think of any reason why that may be an issue but let me know if I should change it to filter only system parachains.
This is the testing script.
Original PR: paritytech/polkadot#7518