Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pallet-balances] burn extrinsic #3943

Closed
2 tasks done
Dinonard opened this issue Apr 2, 2024 · 3 comments
Closed
2 tasks done

[pallet-balances] burn extrinsic #3943

Dinonard opened this issue Apr 2, 2024 · 3 comments
Assignees
@Dinonard
Labels
I5-enhancement An additional feature request.

Comments

@Dinonard
Copy link
Contributor

Dinonard commented Apr 2, 2024

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

On Ethereum we have 0x0000000000000000000000000000000000000000 designated address for burning ETH.

To my knowledge, there's no similar thing provided by the polkadot-sdk.

Request

Add a new extrinsic call (or two) to the pallet-balances, similar to transfer_allow_death/keep_alive calls, which would burn the user specified amount.

Solution

No response

Are you willing to help with this request?

Yes!
@Dinonard Dinonard added the I5-enhancement An additional feature request. label Apr 2, 2024
@bkchr
Copy link
Member

bkchr commented Apr 2, 2024

Sounds reasonable to me! Feel free to open a pr.

@Dinonard
Copy link
Contributor Author

Dinonard commented Apr 3, 2024

Here's the PR: #3964

@Dinonard Dinonard mentioned this issue Apr 3, 2024
Merged
2 tasks
@Dinonard
Copy link
Contributor Author

Can you maybe take a look at the PR when you get the chance? Thanks!

@liamaharon liamaharon moved this to In Development in Asset Improvement Board May 6, 2024
github-merge-queue bot pushed a commit that referenced this issue May 8, 2024
@Dinonard @ggwpez
[pallet-balances] burn_allow_death extrinsic (#3964)
c3e57c1 
Adds an additional extrinsic call to the `pallet-balances` to _burn_
tokens.
Depending on the `keep_alive` flag, the call might or might not reap the
account.

Required modification of the _fungible's_ `Mutate` trait, `burn_from`
function to allow the `Preservation` argument.

**TODO**
- [x] run benchmarks & update weights
- [x] make sure prdoc is required & properly formatted

Related issue: #3943

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
paritytech-ci pushed a commit that referenced this issue May 8, 2024
@Dinonard @ggwpez
[pallet-balances] burn_allow_death extrinsic (#3964)
fecce86 
Adds an additional extrinsic call to the `pallet-balances` to _burn_
tokens.
Depending on the `keep_alive` flag, the call might or might not reap the
account.

Required modification of the _fungible's_ `Mutate` trait, `burn_from`
function to allow the `Preservation` argument.

**TODO**
- [x] run benchmarks & update weights
- [x] make sure prdoc is required & properly formatted

Related issue: #3943

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
@bkchr bkchr closed this as completed May 14, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME May 14, 2024
@github-project-automation github-project-automation bot moved this from In Development to Shipped in Asset Improvement Board May 14, 2024
@liamaharon liamaharon moved this from Shipped to Finalizing in Asset Improvement Board May 17, 2024
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
@Dinonard @ggwpez @hitchhooker
[pallet-balances] burn_allow_death extrinsic (paritytech#3964)
18511d0 
Adds an additional extrinsic call to the `pallet-balances` to _burn_
tokens.
Depending on the `keep_alive` flag, the call might or might not reap the
account.

Required modification of the _fungible's_ `Mutate` trait, `burn_from`
function to allow the `Preservation` argument.

**TODO**
- [x] run benchmarks & update weights
- [x] make sure prdoc is required & properly formatted

Related issue: paritytech#3943

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@Dinonard @ggwpez @TarekkMA
[pallet-balances] burn_allow_death extrinsic (paritytech#3964)
be32209 
Adds an additional extrinsic call to the `pallet-balances` to _burn_
tokens.
Depending on the `keep_alive` flag, the call might or might not reap the
account.

Required modification of the _fungible's_ `Mutate` trait, `burn_from`
function to allow the `Preservation` argument.

**TODO**
- [x] run benchmarks & update weights
- [x] make sure prdoc is required & properly formatted

Related issue: paritytech#3943

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
This was referenced Aug 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dinonard Dinonard

Labels
I5-enhancement An additional feature request.
Projects
Asset Improvement Board
Status: Finalizing
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dinonard @bkchr