Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request revenue info #2209

Closed
2 tasks
eskimor opened this issue Nov 7, 2023 · 0 comments · Fixed by #3940
Closed
2 tasks

Request revenue info #2209

eskimor opened this issue Nov 7, 2023 · 0 comments · Fixed by #3940
Assignees
@s0me0ne-unkn0wn

Comments

@eskimor
Copy link
Member

eskimor commented Nov 7, 2023

Implement request_revenue_info.

  • Keep track of revenue in on-demand
  • Implement call
@eskimor eskimor converted this from a draft issue Nov 7, 2023
@eskimor eskimor changed the title Request reveneue info Request revenue info Nov 7, 2023
@eskimor eskimor moved this from Backlog to In Progress in parachains team board Mar 26, 2024
@eskimor eskimor mentioned this issue May 14, 2024
Merged
5 tasks
@ordian ordian assigned s0me0ne-unkn0wn and unassigned antonva May 16, 2024
@eskimor eskimor moved this from In Progress to Review in progress in parachains team board Jun 5, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 26, 2024
@antonva @s0me0ne-unkn0wn
@seadanda @bkchr
Coretime: Add request revenue info (#3940)
f1db2c6 
Enables the `request_revenue` and `notify_revenue` parts of [RFC 5 -
Coretime
Interface](https://polkadot-fellows.github.io/RFCs/approved/0005-coretime-interface.html)

TODO:
- [x] Finish first pass at implementation
- [x] ~~Need to explicitly burn uncollected and dropped revenue~~
Accumulate it instead
- [x] Confirm working on zombienet
- [x] Tests 
- [ ] Enable XCM `request_revenue` sending on Coretime chain on Kusama
and Polkadot

Fixes: #2209

---------

Co-authored-by: Dmitry Sinyavin <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: s0me0ne-unkn0wn <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
@github-project-automation github-project-automation bot moved this from Review in progress to Completed in parachains team board Jun 26, 2024
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@antonva @s0me0ne-unkn0wn
@seadanda @bkchr @TarekkMA
Coretime: Add request revenue info (paritytech#3940)
b24038b 
Enables the `request_revenue` and `notify_revenue` parts of [RFC 5 -
Coretime
Interface](https://polkadot-fellows.github.io/RFCs/approved/0005-coretime-interface.html)

TODO:
- [x] Finish first pass at implementation
- [x] ~~Need to explicitly burn uncollected and dropped revenue~~
Accumulate it instead
- [x] Confirm working on zombienet
- [x] Tests 
- [ ] Enable XCM `request_revenue` sending on Coretime chain on Kusama
and Polkadot

Fixes: paritytech#2209

---------

Co-authored-by: Dmitry Sinyavin <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: s0me0ne-unkn0wn <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s0me0ne-unkn0wn s0me0ne-unkn0wn

Labels
None yet
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Coretime: Add request revenue info paritytech/polkadot-sdk
3 participants
@eskimor @antonva @s0me0ne-unkn0wn