Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update translate to use defensive! #1323

Closed
xlc opened this issue Aug 30, 2023 · 0 comments · Fixed by #2985
Closed

Update translate to use defensive! #1323

xlc opened this issue Aug 30, 2023 · 0 comments · Fixed by #2985
Assignees
@liamaharon
Labels
I5-enhancement An additional feature request.

Comments

@xlc
Copy link
Contributor

xlc commented Aug 30, 2023 

          so we should update `translate` to use `defensive!`

Originally posted by @xlc in #1290 (comment)

So that it will be a hard fail in test
@xlc xlc mentioned this issue Jan 18, 2024
Closed
19 tasks
@liamaharon liamaharon added T1-FRAME This PR/Issue is related to core FRAME, the framework. I5-enhancement An additional feature request. and removed T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Jan 18, 2024
@liamaharon liamaharon self-assigned this Jan 18, 2024
@liamaharon liamaharon mentioned this issue Jan 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 19, 2024
@liamaharon @joepetrowski @bkchr
Update translate to use defensive! (#2985)
697c2c3 
Closes #1323 

cc @xlc

---------

Co-authored-by: joe petrowski <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@liamaharon @joepetrowski @bkchr
Update translate to use defensive! (paritytech#2985)
3dc890c 
Closes paritytech#1323 

cc @xlc

---------

Co-authored-by: joe petrowski <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamaharon liamaharon

Labels
I5-enhancement An additional feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update translate to use defensive! paritytech/polkadot-sdk
2 participants
@xlc @liamaharon