Custom user errors #80
Conversation
src/interpreter/mod.rs
Outdated
| @@ -1,8 +1,12 @@ | |||
| //! WebAssembly interpreter module. | |||
|
|
|||
| /// Interpreter error. | |||
| /// Custom user error. | |||
| pub trait CustomUserError: 'static + ::std::fmt::Display + ::std::fmt::Debug + Clone + PartialEq { | |||
There was a problem hiding this comment.
maybe call it UserError?
I'm worried about a lot entries in public api are named as SomethingSomethingThing
src/interpreter/mod.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| /// Dummy user error. | ||
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct DummyCustomUserError; |
There was a problem hiding this comment.
maybe call it just Dummy and refer as error::Dummy everywhere
There was a problem hiding this comment.
So you're suggesting to add additional namespace (error) and move this struct over there (maybe I got it wrong)? Looks like additional headache for me, but if you feel this is ok - please insist.
For now I have renamed it to DummyUserError && added alias DummyError for Error<DummyUserError>. Unfortunately, because of this issue: rust-lang/rust#26264 you still need to import both Error && DummyError, if you want to access Error variants
There was a problem hiding this comment.
ah ok, it's ok with just rename
closes #20
Most significant API changes:
: ::std::fmt::Display + ::std::fmt::Debug + Clone + PartialEqMost of changes are just cosmetic (propagating generic parameter). Example is in
native_custom_error