Implement ExportXcm and MessageDispatch for pallet-xcm-bridge-hub #2285
+339
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
P-Runtime
PR-audit-needed
svyatonik
commented
Jul 20, 2023
| @@ -0,0 +1,103 @@ | |||
| // Copyright 2019-2021 Parity Technologies (UK) Ltd. | |||
There was a problem hiding this comment.
This file is almost 1:1 copy of the XcmBlobMessageDispatch. The only difference is that it is now implemented for the Pallet, instead of a dedicated struct
svyatonik
commented
Jul 20, 2023
| @@ -0,0 +1,184 @@ | |||
| // Copyright 2019-2021 Parity Technologies (UK) Ltd. | |||
There was a problem hiding this comment.
Here, I had to change the original XcmBlobHaulerAdapter a bit, because it doesn't work well with dynamic lanes. So it needs more careful review
acatangiu
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to:
XcmBlobHaulerAdapterthat supports dynamic configuration;pallet-xcm-bridge-hub) to bothExportXcmandMessageDispatchto support backpressure on bridge/XCM queues.So this PR adds implementation of
ExportXcmandMessageDispatchto the recentpallet-xcm-bridge-hub. In the future we'll migrate Rialto<>Millau and then other bridges to this pallet, sobridge_runtime_common::XcmBlobHaulerAdapterandbridge_runtime_common::XcmBlobMessageDispatchwill dissolve. Right now it's just a code that isn't used anywhere, bu as I mentioned, I need it to progress on #2261.If we'll be implementing dynamic fees in V1 (without dynamic lanes), we'll probably keep using existing
bridge_runtime_common::XcmBlobHaulerAdapterandbridge_runtime_common::XcmBlobMessageDispatch. Then we'll need a totally separate PR to thepolkadot-stagingbranch.