Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate parity-bridges-common repo to polkadot-sdk repo #2538

Closed
6 tasks done
acatangiu opened this issue Sep 5, 2023 · 4 comments
Closed
6 tasks done

Migrate parity-bridges-common repo to polkadot-sdk repo #2538

acatangiu opened this issue Sep 5, 2023 · 4 comments
Assignees
@serban300
Milestone
Kusama <> Polkado...

Comments

@acatangiu
Copy link
Collaborator

acatangiu commented Sep 5, 2023 •
edited by serban300
Loading

The point is to move (ideally everything) from https://github.com/paritytech/parity-bridges-common repo to https://github.com/paritytech/polkadot-sdk repo.

Right now we're already manually syncing/copying (parts of the) following dirs:

bin		modules		docs		primitives		scripts

as they're needed by several system parachains (BridgeHubs and AssetHubs).

Prerequisites for full migration

Main "blocker" is the fact that our bridge test deployments are using custom chains millau, rialto and custom parachain rialto-parachain.

We are testing the bridge by (re)deploying the chains, the bridge and the relayers every morning with latest changes and letting it run for ~24h.

We don't want to bring in Rialto, Millau to polkado-sdk so first thing to do is move our nightly test deployments to use Rococo<>Wococo (and their BridgeHub and AssetHub parachains).
A blocker here is that RococoAH is deployed from KusamaAH code which doesn't contain bridging functionality, so we need paritytech/polkadot-sdk#1128 + paritytech/polkadot-sdk#1215.

List
@acatangiu acatangiu added this to the Nice To Have milestone Sep 5, 2023
@acatangiu acatangiu moved this from Draft to Open in Parity Roadmap Sep 5, 2023
@acatangiu acatangiu mentioned this issue Sep 5, 2023
Merged
@bkontur
Copy link
Contributor

bkontur commented Sep 5, 2023

I had this question on last bridges meeting:

When we move production runtimes for Kusama/Polkadot to the polkadot-fellows repository, where do we place/keep relayer-related configuration/code?

polkadot-sdk or old parity-bridges-common or polkadot-fellows or somewhere else?

@acatangiu
Copy link
Collaborator Author

I am taking an educated guess that we'll keep everything in polkadot-sdk - where there's also still going to be runtimes (Rococo, Westend, Wococo). Only Polkadot, Kusama and their SystemParachains will move to polkadot-fellows.

And I'm guessing polkadot-fellows runtimes will just depend on bridge crates in polkadot-sdk just as they depend on substrate crates etc.

@Lord-Nymphis Lord-Nymphis mentioned this issue Jan 12, 2024
Merged
18 tasks
@bkontur bkontur mentioned this issue Jan 18, 2024
Merged
@serban300 serban300 self-assigned this Feb 26, 2024
@serban300 serban300 mentioned this issue Mar 18, 2024
Merged
@serban300
Copy link
Collaborator

Discussed the document proposing the migration strategy with the team: https://hackmd.io/LprWjZ0bQXKpFeveYHIRXw?view.

We have agreed on the next steps and will start implementing them.

@serban300 serban300 mentioned this issue Mar 25, 2024
Merged
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this issue Mar 25, 2024
@serban300
[Bridges] Move chain definitions to separate folder (#3822)
0711729 
Related to
paritytech/parity-bridges-common#2538

This PR doesn't contain any functional changes. 

The PR moves specific bridged chain definitions from
`bridges/primitives` to `bridges/chains` folder in order to facilitate
the migration of the `parity-bridges-repo` into `polkadot-sdk` as
discussed in https://hackmd.io/LprWjZ0bQXKpFeveYHIRXw?view

Apart from this it also includes some cosmetic changes to some
`Cargo.toml` files as a result of running `diener workspacify`.
serban300 added a commit to serban300/parity-bridges-common that referenced this issue Mar 25, 2024
@serban300
[Bridges] Move chain definitions to separate folder (#3822)
aab42d4 
Related to
paritytech#2538

This PR doesn't contain any functional changes.

The PR moves specific bridged chain definitions from
`bridges/primitives` to `bridges/chains` folder in order to facilitate
the migration of the `parity-bridges-repo` into `polkadot-sdk` as
discussed in https://hackmd.io/LprWjZ0bQXKpFeveYHIRXw?view

Apart from this it also includes some cosmetic changes to some
`Cargo.toml` files as a result of running `diener workspacify`.

(cherry picked from commit 0711729d251efebf3486db602119ecfa67d98366)
@serban300 serban300 mentioned this issue Mar 25, 2024
Merged
serban300 added a commit that referenced this issue Mar 25, 2024
@serban300
[Backport from polkadot-sdk] Move chain definitions to separate fol…
4bc73d8 
…der (#2892)

* [Bridges] Move chain definitions to separate folder (#3822)

Related to
#2538

This PR doesn't contain any functional changes.

The PR moves specific bridged chain definitions from
`bridges/primitives` to `bridges/chains` folder in order to facilitate
the migration of the `parity-bridges-repo` into `polkadot-sdk` as
discussed in https://hackmd.io/LprWjZ0bQXKpFeveYHIRXw?view

Apart from this it also includes some cosmetic changes to some
`Cargo.toml` files as a result of running `diener workspacify`.

(cherry picked from commit 0711729d251efebf3486db602119ecfa67d98366)

* diener workspacify
This was referenced Mar 25, 2024
Merged
Merged
serban300 added a commit to serban300/parity-bridges-common that referenced this issue Mar 27, 2024
@serban300
[Backport from polkadot-sdk] Move chain definitions to separate fol…
c7eec49 
…der (paritytech#2892)

* [Bridges] Move chain definitions to separate folder (#3822)

Related to
paritytech#2538

This PR doesn't contain any functional changes.

The PR moves specific bridged chain definitions from
`bridges/primitives` to `bridges/chains` folder in order to facilitate
the migration of the `parity-bridges-repo` into `polkadot-sdk` as
discussed in https://hackmd.io/LprWjZ0bQXKpFeveYHIRXw?view

Apart from this it also includes some cosmetic changes to some
`Cargo.toml` files as a result of running `diener workspacify`.

(cherry picked from commit 0711729d251efebf3486db602119ecfa67d98366)

* diener workspacify
This was referenced Apr 1, 2024
Merged
Merged
Merged
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this issue Apr 2, 2024
@serban300
Align dependencies with parity-bridges-common (#3937)
8e95a3e 
Working towards migrating the `parity-bridges-common` repo inside
`polkadot-sdk`. This PR upgrades some dependencies in order to align
them with the versions used in `parity-bridges-common`

Related to
paritytech/parity-bridges-common#2538
serban300 added a commit to serban300/parity-bridges-common that referenced this issue Apr 8, 2024
@serban300
[Backport from polkadot-sdk] Move chain definitions to separate fol…
2ab42b0 
…der (paritytech#2892)

* [Bridges] Move chain definitions to separate folder (#3822)

Related to
paritytech#2538

This PR doesn't contain any functional changes.

The PR moves specific bridged chain definitions from
`bridges/primitives` to `bridges/chains` folder in order to facilitate
the migration of the `parity-bridges-repo` into `polkadot-sdk` as
discussed in https://hackmd.io/LprWjZ0bQXKpFeveYHIRXw?view

Apart from this it also includes some cosmetic changes to some
`Cargo.toml` files as a result of running `diener workspacify`.

(cherry picked from commit 0711729d251efebf3486db602119ecfa67d98366)

* diener workspacify
Ank4n pushed a commit to paritytech/polkadot-sdk that referenced this issue Apr 9, 2024
@serban300 @Ank4n
Align dependencies with parity-bridges-common (#3937)
8164280 
Working towards migrating the `parity-bridges-common` repo inside
`polkadot-sdk`. This PR upgrades some dependencies in order to align
them with the versions used in `parity-bridges-common`

Related to
paritytech/parity-bridges-common#2538
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Apr 9, 2024
@serban300 @dharjeezy
[Bridges] Move chain definitions to separate folder (paritytech#3822)
94dbdea 
Related to
paritytech/parity-bridges-common#2538

This PR doesn't contain any functional changes. 

The PR moves specific bridged chain definitions from
`bridges/primitives` to `bridges/chains` folder in order to facilitate
the migration of the `parity-bridges-repo` into `polkadot-sdk` as
discussed in https://hackmd.io/LprWjZ0bQXKpFeveYHIRXw?view

Apart from this it also includes some cosmetic changes to some
`Cargo.toml` files as a result of running `diener workspacify`.
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Apr 9, 2024
@serban300 @dharjeezy
Align dependencies with parity-bridges-common (paritytech#3937)
a066bdd 
Working towards migrating the `parity-bridges-common` repo inside
`polkadot-sdk`. This PR upgrades some dependencies in order to align
them with the versions used in `parity-bridges-common`

Related to
paritytech/parity-bridges-common#2538
bkchr pushed a commit to paritytech/polkadot-sdk that referenced this issue Apr 10, 2024
@serban300 @bkchr
[Backport from polkadot-sdk] Move chain definitions to separate fol…
9b685d5 
…der (#2892)

* [Bridges] Move chain definitions to separate folder (#3822)

Related to
paritytech/parity-bridges-common#2538

This PR doesn't contain any functional changes.

The PR moves specific bridged chain definitions from
`bridges/primitives` to `bridges/chains` folder in order to facilitate
the migration of the `parity-bridges-repo` into `polkadot-sdk` as
discussed in https://hackmd.io/LprWjZ0bQXKpFeveYHIRXw?view

Apart from this it also includes some cosmetic changes to some
`Cargo.toml` files as a result of running `diener workspacify`.

(cherry picked from commit 0711729)

* diener workspacify
This was referenced Apr 10, 2024
Merged
Merged
Open
@serban300
Copy link
Collaborator

Closing this issue since the code migration has been completed.

Created a new issue containing what is left to be done: #2950

@github-project-automation github-project-automation bot moved this from Open to Done in Parity Roadmap Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serban300 serban300

Labels
None yet
Projects
Parity Roadmap
Status: Done
Milestone
Kusama <> Polkadot Parachain Bridge R...
Development

No branches or pull requests
3 participants
@bkontur @serban300 @acatangiu