server: make it possible to enable ws/http only #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Nov 17, 2022
niklasad1
commented
Nov 17, 2022
| /// except if you have enabled middleware which are processed before this check occurs. | ||
| /// | ||
| /// Default: both http and ws are enabled. | ||
| pub fn ws_only(mut self) -> Self { |
There was a problem hiding this comment.
@lexnv this is a bit opinionated but I would like to have it for consistency.
There was a problem hiding this comment.
this would disable all JSON-RPC HTTP requests and just reply 403 on all HTTP requests (including middleware as well), works exactly as the ws-server in v0.15
niklasad1
commented
Nov 17, 2022
lexnv
reviewed
Nov 17, 2022
Co-authored-by: Alexandru Vasile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.