Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add async wasm feature to facade crate #893

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Oct 4, 2022

This is useful when doing conditional compilation for supporting both ws-client and wasm from the jsonrpsee root crate instead having to import the jsonrpsee-wasm-client for the wasm stuff and jsonrpsee for rest of the clients.

See example here, it's a bit niche feature quite useful but we can also skip it because of technical debt of all different features.

@niklasad1 niklasad1 requested a review from a team as a code owner October 4, 2022 14:00
@niklasad1 niklasad1 merged commit a7108a7 into master Oct 5, 2022
@niklasad1 niklasad1 deleted the na-async-wasm-feature branch October 5, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants