Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix client generation with param_kind = map #805

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Fix client generation with param_kind = map #805

merged 1 commit into from
Jun 23, 2022

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Jun 23, 2022

No description provided.

@vorot93 vorot93 requested a review from a team as a code owner June 23, 2022 10:43
niklasad1
niklasad1 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lexnv
lexnv approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@niklasad1 niklasad1 merged commit 610f635 into paritytech:master Jun 23, 2022
@vorot93 vorot93 deleted the patch-1 branch June 23, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vorot93 @jsdw @niklasad1 @lexnv