Hide internal macros from public interface #755
Conversation
| @@ -11,19 +10,19 @@ macro_rules! cfg_feature { | |||
|
|
|||
| macro_rules! cfg_client { | |||
| ($($item:item)*) => { | |||
| $crate::cfg_feature!("client", $($item)*); | |||
| cfg_feature!("client", $($item)*); | |||
There was a problem hiding this comment.
I wasn't sure without trying, but things seem to work fine without properly namespacing the macro!
There was a problem hiding this comment.
Hmm, here be dragons. I think there are situations when this will not work well, but can't remember what the full story was. $crate::macros::cfg_feature! should work though right?
| @@ -1,4 +1,3 @@ | |||
| #[macro_export] | |||
There was a problem hiding this comment.
It's this macro_export which makes the macro part of the public interface I believe.
| @@ -11,19 +10,19 @@ macro_rules! cfg_feature { | |||
|
|
|||
| macro_rules! cfg_client { | |||
| ($($item:item)*) => { | |||
| $crate::cfg_feature!("client", $($item)*); | |||
| cfg_feature!("client", $($item)*); | |||
There was a problem hiding this comment.
Hmm, here be dragons. I think there are situations when this will not work well, but can't remember what the full story was. $crate::macros::cfg_feature! should work though right?
should be alright because they are internal anyway, so if it works in the CI that should be sufficent |
|
Great James, I looked at the generated docs and looks good :) |
The title says it all :)