Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: try nextest #701

Merged
merged 2 commits into from
Feb 16, 2022
Merged

CI: try nextest #701

merged 2 commits into from
Feb 16, 2022

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Feb 15, 2022

An attempt to switch to cargo-nextest.

Note it doesn't support doctests so they should be run separately.
@dvdplm @niklasad1 could you suggest a good way of getting the list of doctests please?


Oh lovely.
So nextest with some cache (on the second run) performed like this
image

instead of a regular cargo test
image

it's worth mentioning though that without cache it takes another ~3m30s to install the tool. Thankfully, there's a cached cargo-install.
image

@TriplEight TriplEight requested review from a team as code owners February 15, 2022 15:47
@TriplEight TriplEight self-assigned this Feb 15, 2022
@TriplEight TriplEight added the github_actions Pull requests that update Github_actions code label Feb 15, 2022
@niklasad1
Copy link
Member

cool, it's 1 minute faster than cargo test

@TriplEight TriplEight requested a review from alvicsam February 15, 2022 18:20
@TriplEight TriplEight merged commit afdf57d into master Feb 16, 2022
@TriplEight TriplEight deleted the 3x8_nextest branch February 16, 2022 11:14
@niklasad1
Copy link
Member

niklasad1 commented Feb 16, 2022

@TriplEight

hrm, I would like at least one approval from the tools team before merging any PRs to this repo in future.

We rely heavily on doc tests and we need have to doc tests enabled to be sure that we don't miss any tests.

I'll create a follow--up PR to add that back

@TriplEight
Copy link
Contributor Author

@niklasad1 sorry for that, noted.
https://github.com/paritytech/jsonrpsee/blob/master/.github/workflows/ci.yml#L46 or
https://github.com/paritytech/jsonrpsee/blob/master/.gitlab-ci.yml#L99 I missed that these are not running all the doctests.
Anyway, doctests usually do not require compilation and can be safely separated to another job.

The follow-up issue to work on this repo is here https://github.com/paritytech/ci_cd/issues/333
And this is how we'll prepare to the nextest deployment next time https://github.com/paritytech/ci_cd/issues/334
Please feel free to add your ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants